fix: ChangePackage from packageName is part of the submodule dir name issue

Open qxo opened this issue 3 months ago • 2 comments

ie:

submodule name: p1-core and ChangePackage from: p1.sub1-> to: p2.sub1

before this pr result ->  p2-core/src/java/sub1/xx
after  this pr result   -> p1-core/src/java/p2/sub1/xx

What's changed?

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

[ ] I've added unit tests to cover both positive and negative cases
[ ] I've read and applied the recipe conventions and best practices
[ ] I've used the IntelliJ IDEA auto-formatter on affected files

Sep 20 '25 13:09 qxo

hi @qxo ; thanks for noticing and reporting here! It appears there's a few tests that now no longer pass, copied here for convenience:

ChangePackageAdaptabilityTest > changePackage() FAILED
    java.lang.AssertionError: Failed to run recipe at Cursor{CompilationUnit->root}
        at org.openrewrite.test.RewriteTest.lambda$defaultExecutionContext$14(RewriteTest.java:644)
        at org.openrewrite.test.RewriteTest$$Lambda/0x00007f1f241a55d8.accept(Unknown Source)
        at org.openrewrite.scheduling.RecipeRunCycle.handleError(RecipeRunCycle.java:291)
        at org.openrewrite.scheduling.RecipeRunCycle.lambda$editSources$8(RecipeRunCycle.java:230)
        at org.openrewrite.scheduling.RecipeRunCycle$$Lambda/0x00007f1f243b84c0.apply(Unknown Source)
        at org.openrewrite.scheduling.RecipeStack.reduce(RecipeStack.java:60)
        at org.openrewrite.scheduling.RecipeRunCycle.lambda$editSources$9(RecipeRunCycle.java:179)
        at org.openrewrite.scheduling.RecipeRunCycle$$Lambda/0x00007f1f243b8000.apply(Unknown Source)
        at org.openrewrite.internal.InMemoryLargeSourceSet.lambda$edit$0(InMemoryLargeSourceSet.java:86)
        at org.openrewrite.internal.InMemoryLargeSourceSet$$Lambda/0x00007f1f243b8260.apply(Unknown Source)
        at org.openrewrite.internal.ListUtils.map(ListUtils.java:245)
        at org.openrewrite.internal.ListUtils.map(ListUtils.java:269)
        at org.openrewrite.internal.InMemoryLargeSourceSet.edit(InMemoryLargeSourceSet.java:85)
        at org.openrewrite.RecipeScheduler$$Lambda/0x00007f1f243b7b18.apply(Unknown Source)
        at org.openrewrite.scheduling.RecipeRunCycle.editSources(RecipeRunCycle.java:177)
        at org.openrewrite.RecipeScheduler.runRecipeCycles(RecipeScheduler.java:84)
        at org.openrewrite.RecipeScheduler.scheduleRun(RecipeScheduler.java:41)
        at org.openrewrite.Recipe.run(Recipe.java:442)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:382)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:130)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:125)
        at org.openrewrite.groovy.ChangePackageAdaptabilityTest.changePackage(ChangePackageAdaptabilityTest.java:43)

        Caused by:
        org.openrewrite.internal.RecipeRunException: java.lang.StringIndexOutOfBoundsException: Range [0, -1) out of bounds for length 11
            at app//org.openrewrite.TreeVisitor.visit(TreeVisitor.java:278)
            at app//org.openrewrite.TreeVisitor.visit(TreeVisitor.java:154)
            at app//org.openrewrite.java.ChangePackage$2.preVisit(ChangePackage.java:141)
            at app//org.openrewrite.java.ChangePackage$2.preVisit(ChangePackage.java:131)
            at app//org.openrewrite.TreeVisitor.visit(TreeVisitor.java:239)
            at app//org.openrewrite.TreeVisitor.visit(TreeVisitor.java:154)
            at app//org.openrewrite.Preconditions$Check.visit(Preconditions.java:175)
            at app//org.openrewrite.Preconditions$Check.visit(Preconditions.java:145)
            at app//org.openrewrite.scheduling.RecipeRunCycle.lambda$editSources$7(RecipeRunCycle.java:210)
            at app//org.openrewrite.scheduling.RecipeRunCycle$$Lambda/0x00007f1f243b9be8.call(Unknown Source)
            at app//io.micrometer.core.instrument.AbstractTimer.recordCallable(AbstractTimer.java:147)
            at app//org.openrewrite.table.RecipeRunStats.recordEdit(RecipeRunStats.java:74)
            at app//org.openrewrite.scheduling.RecipeRunCycle.lambda$editSources$8(RecipeRunCycle.java:206)
            ... 18 more

            Caused by:
            java.lang.StringIndexOutOfBoundsException: Range [0, -1) out of bounds for length 11
                at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
                at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
                at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
                at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
                at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
                at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckFromToIndex(Preconditions.java:112)
                at java.base/jdk.internal.util.Preconditions.checkFromToIndex(Preconditions.java:349)
                at java.base/java.lang.String.checkBoundsBeginEnd(String.java:4865)
                at java.base/java.lang.String.substring(String.java:2834)
                at org.openrewrite.java.ChangePackage$JavaChangePackageVisitor.postVisit(ChangePackage.java:263)
                at org.openrewrite.java.ChangePackage$JavaChangePackageVisitor.postVisit(ChangePackage.java:158)
                at org.openrewrite.TreeVisitor.visit(TreeVisitor.java:245)
                ... 30 more

ChangePackageAdaptabilityTest > fullyQualified() FAILED
    java.lang.AssertionError: Failed to run recipe at Cursor{CompilationUnit->root}
        at org.openrewrite.test.RewriteTest.lambda$defaultExecutionContext$14(RewriteTest.java:644)
        at org.openrewrite.test.RewriteTest$$Lambda/0x00007f1f241a55d8.accept(Unknown Source)
        at org.openrewrite.scheduling.RecipeRunCycle.handleError(RecipeRunCycle.java:291)
        at org.openrewrite.scheduling.RecipeRunCycle.lambda$editSources$8(RecipeRunCycle.java:230)
        at org.openrewrite.scheduling.RecipeRunCycle$$Lambda/0x00007f1f243b84c0.apply(Unknown Source)
        at org.openrewrite.scheduling.RecipeStack.reduce(RecipeStack.java:60)
        at org.openrewrite.scheduling.RecipeRunCycle.lambda$editSources$9(RecipeRunCycle.java:179)
        at org.openrewrite.scheduling.RecipeRunCycle$$Lambda/0x00007f1f243b8000.apply(Unknown Source)
        at org.openrewrite.internal.InMemoryLargeSourceSet.lambda$edit$0(InMemoryLargeSourceSet.java:86)
        at org.openrewrite.internal.InMemoryLargeSourceSet$$Lambda/0x00007f1f243b8260.apply(Unknown Source)
        at org.openrewrite.internal.ListUtils.map(ListUtils.java:245)
        at org.openrewrite.internal.ListUtils.map(ListUtils.java:269)
        at org.openrewrite.internal.InMemoryLargeSourceSet.edit(InMemoryLargeSourceSet.java:85)
        at org.openrewrite.RecipeScheduler$$Lambda/0x00007f1f243b7b18.apply(Unknown Source)
        at org.openrewrite.scheduling.RecipeRunCycle.editSources(RecipeRunCycle.java:177)
        at org.openrewrite.RecipeScheduler.runRecipeCycles(RecipeScheduler.java:84)
        at org.openrewrite.RecipeScheduler.scheduleRun(RecipeScheduler.java:41)
        at org.openrewrite.Recipe.run(Recipe.java:442)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:382)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:130)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:125)
        at org.openrewrite.groovy.ChangePackageAdaptabilityTest.fullyQualified(ChangePackageAdaptabilityTest.java:76)

        Caused by:
        org.openrewrite.internal.RecipeRunException: java.lang.StringIndexOutOfBoundsException: Range [0, -1) out of bounds for length 11
            at app//org.openrewrite.TreeVisitor.visit(TreeVisitor.java:278)
            at app//org.openrewrite.TreeVisitor.visit(TreeVisitor.java:154)
            at app//org.openrewrite.java.ChangePackage$2.preVisit(ChangePackage.java:141)
            at app//org.openrewrite.java.ChangePackage$2.preVisit(ChangePackage.java:131)
            at app//org.openrewrite.TreeVisitor.visit(TreeVisitor.java:239)
            at app//org.openrewrite.TreeVisitor.visit(TreeVisitor.java:154)
            at app//org.openrewrite.Preconditions$Check.visit(Preconditions.java:175)
            at app//org.openrewrite.Preconditions$Check.visit(Preconditions.java:145)
            at app//org.openrewrite.scheduling.RecipeRunCycle.lambda$editSources$7(RecipeRunCycle.java:210)
            at app//org.openrewrite.scheduling.RecipeRunCycle$$Lambda/0x00007f1f243b9be8.call(Unknown Source)
            at app//io.micrometer.core.instrument.AbstractTimer.recordCallable(AbstractTimer.java:147)
            at app//org.openrewrite.table.RecipeRunStats.recordEdit(RecipeRunStats.java:74)
            at app//org.openrewrite.scheduling.RecipeRunCycle.lambda$editSources$8(RecipeRunCycle.java:206)
            ... 18 more

            Caused by:
            java.lang.StringIndexOutOfBoundsException: Range [0, -1) out of bounds for length 11
                at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
                at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
                at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
                at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
                at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
                at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckFromToIndex(Preconditions.java:112)
                at java.base/jdk.internal.util.Preconditions.checkFromToIndex(Preconditions.java:349)
                at java.base/java.lang.String.checkBoundsBeginEnd(String.java:4865)
                at java.base/java.lang.String.substring(String.java:2834)
                at org.openrewrite.java.ChangePackage$JavaChangePackageVisitor.postVisit(ChangePackage.java:263)
                at org.openrewrite.java.ChangePackage$JavaChangePackageVisitor.postVisit(ChangePackage.java:158)
                at org.openrewrite.TreeVisitor.visit(TreeVisitor.java:245)
                ... 30 more

ChangePackageAdaptabilityTest > changeDefinition() FAILED
    org.opentest4j.AssertionFailedError: 
    expected: "x/y/z/Test.groovy"
     but was: "org/foo/Test.groovy"
        at app//org.openrewrite.groovy.ChangePackageAdaptabilityTest.lambda$changeDefinition$4(ChangePackageAdaptabilityTest.java:143)
        at app//org.openrewrite.groovy.ChangePackageAdaptabilityTest$$Lambda/0x00007f1f245213d8.accept0(Unknown Source)
        at app//org.openrewrite.internal.ThrowingConsumer.accept(ThrowingConsumer.java:26)
        at app//org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:554)
        at app//org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:130)
        at app//org.openrewrite.groovy.ChangePackageAdaptabilityTest.changeDefinition(ChangePackageAdaptabilityTest.java:129)

ChangePackageAdaptabilityTest > renamePackageRecursive() FAILED
    org.opentest4j.AssertionFailedError: 
    expected: "org/foo/test/internal/Test.groovy"
     but was: "org/foo/internal/Test.groovy"
        at app//org.openrewrite.groovy.ChangePackageAdaptabilityTest.lambda$renamePackageRecursive$1(ChangePackageAdaptabilityTest.java:119)
        at app//org.openrewrite.groovy.ChangePackageAdaptabilityTest$$Lambda/0x00007f1f2452e9d8.accept0(Unknown Source)
        at app//org.openrewrite.internal.ThrowingConsumer.accept(ThrowingConsumer.java:26)
        at app//org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:554)
        at app//org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:130)
        at app//org.openrewrite.groovy.ChangePackageAdaptabilityTest.renamePackageRecursive(ChangePackageAdaptabilityTest.java:105)

Would you mind taking a look at those? Could also be helpful to have a test that would have failed previously but now passes, just to avoid any regressions in the future.

Sep 21 '25 15:09 timtebeek

hi @qxo ; thanks for noticing and reporting here! It appears there's a few tests that now no longer pass, copied here for convenience:

ChangePackageAdaptabilityTest > changePackage() FAILED
    java.lang.AssertionError: Failed to run recipe at Cursor{CompilationUnit->root}
        at org.openrewrite.test.RewriteTest.lambda$defaultExecutionContext$14(RewriteTest.java:644)
        at org.openrewrite.test.RewriteTest$$Lambda/0x00007f1f241a55d8.accept(Unknown Source)
        at org.openrewrite.scheduling.RecipeRunCycle.handleError(RecipeRunCycle.java:291)
        at org.openrewrite.scheduling.RecipeRunCycle.lambda$editSources$8(RecipeRunCycle.java:230)
        at org.openrewrite.scheduling.RecipeRunCycle$$Lambda/0x00007f1f243b84c0.apply(Unknown Source)
        at org.openrewrite.scheduling.RecipeStack.reduce(RecipeStack.java:60)
        at org.openrewrite.scheduling.RecipeRunCycle.lambda$editSources$9(RecipeRunCycle.java:179)
        at org.openrewrite.scheduling.RecipeRunCycle$$Lambda/0x00007f1f243b8000.apply(Unknown Source)
        at org.openrewrite.internal.InMemoryLargeSourceSet.lambda$edit$0(InMemoryLargeSourceSet.java:86)
        at org.openrewrite.internal.InMemoryLargeSourceSet$$Lambda/0x00007f1f243b8260.apply(Unknown Source)
        at org.openrewrite.internal.ListUtils.map(ListUtils.java:245)
        at org.openrewrite.internal.ListUtils.map(ListUtils.java:269)
        at org.openrewrite.internal.InMemoryLargeSourceSet.edit(InMemoryLargeSourceSet.java:85)
        at org.openrewrite.RecipeScheduler$$Lambda/0x00007f1f243b7b18.apply(Unknown Source)
        at org.openrewrite.scheduling.RecipeRunCycle.editSources(RecipeRunCycle.java:177)
        at org.openrewrite.RecipeScheduler.runRecipeCycles(RecipeScheduler.java:84)
        at org.openrewrite.RecipeScheduler.scheduleRun(RecipeScheduler.java:41)
        at org.openrewrite.Recipe.run(Recipe.java:442)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:382)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:130)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:125)
        at org.openrewrite.groovy.ChangePackageAdaptabilityTest.changePackage(ChangePackageAdaptabilityTest.java:43)

        Caused by:
        org.openrewrite.internal.RecipeRunException: java.lang.StringIndexOutOfBoundsException: Range [0, -1) out of bounds for length 11
            at app//org.openrewrite.TreeVisitor.visit(TreeVisitor.java:278)
            at app//org.openrewrite.TreeVisitor.visit(TreeVisitor.java:154)
            at app//org.openrewrite.java.ChangePackage$2.preVisit(ChangePackage.java:141)
            at app//org.openrewrite.java.ChangePackage$2.preVisit(ChangePackage.java:131)
            at app//org.openrewrite.TreeVisitor.visit(TreeVisitor.java:239)
            at app//org.openrewrite.TreeVisitor.visit(TreeVisitor.java:154)
            at app//org.openrewrite.Preconditions$Check.visit(Preconditions.java:175)
            at app//org.openrewrite.Preconditions$Check.visit(Preconditions.java:145)
            at app//org.openrewrite.scheduling.RecipeRunCycle.lambda$editSources$7(RecipeRunCycle.java:210)
            at app//org.openrewrite.scheduling.RecipeRunCycle$$Lambda/0x00007f1f243b9be8.call(Unknown Source)
            at app//io.micrometer.core.instrument.AbstractTimer.recordCallable(AbstractTimer.java:147)
            at app//org.openrewrite.table.RecipeRunStats.recordEdit(RecipeRunStats.java:74)
            at app//org.openrewrite.scheduling.RecipeRunCycle.lambda$editSources$8(RecipeRunCycle.java:206)
            ... 18 more

            Caused by:
            java.lang.StringIndexOutOfBoundsException: Range [0, -1) out of bounds for length 11
                at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
                at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
                at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
                at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
                at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
                at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckFromToIndex(Preconditions.java:112)
                at java.base/jdk.internal.util.Preconditions.checkFromToIndex(Preconditions.java:349)
                at java.base/java.lang.String.checkBoundsBeginEnd(String.java:4865)
                at java.base/java.lang.String.substring(String.java:2834)
                at org.openrewrite.java.ChangePackage$JavaChangePackageVisitor.postVisit(ChangePackage.java:263)
                at org.openrewrite.java.ChangePackage$JavaChangePackageVisitor.postVisit(ChangePackage.java:158)
                at org.openrewrite.TreeVisitor.visit(TreeVisitor.java:245)
                ... 30 more

ChangePackageAdaptabilityTest > fullyQualified() FAILED
    java.lang.AssertionError: Failed to run recipe at Cursor{CompilationUnit->root}
        at org.openrewrite.test.RewriteTest.lambda$defaultExecutionContext$14(RewriteTest.java:644)
        at org.openrewrite.test.RewriteTest$$Lambda/0x00007f1f241a55d8.accept(Unknown Source)
        at org.openrewrite.scheduling.RecipeRunCycle.handleError(RecipeRunCycle.java:291)
        at org.openrewrite.scheduling.RecipeRunCycle.lambda$editSources$8(RecipeRunCycle.java:230)
        at org.openrewrite.scheduling.RecipeRunCycle$$Lambda/0x00007f1f243b84c0.apply(Unknown Source)
        at org.openrewrite.scheduling.RecipeStack.reduce(RecipeStack.java:60)
        at org.openrewrite.scheduling.RecipeRunCycle.lambda$editSources$9(RecipeRunCycle.java:179)
        at org.openrewrite.scheduling.RecipeRunCycle$$Lambda/0x00007f1f243b8000.apply(Unknown Source)
        at org.openrewrite.internal.InMemoryLargeSourceSet.lambda$edit$0(InMemoryLargeSourceSet.java:86)
        at org.openrewrite.internal.InMemoryLargeSourceSet$$Lambda/0x00007f1f243b8260.apply(Unknown Source)
        at org.openrewrite.internal.ListUtils.map(ListUtils.java:245)
        at org.openrewrite.internal.ListUtils.map(ListUtils.java:269)
        at org.openrewrite.internal.InMemoryLargeSourceSet.edit(InMemoryLargeSourceSet.java:85)
        at org.openrewrite.RecipeScheduler$$Lambda/0x00007f1f243b7b18.apply(Unknown Source)
        at org.openrewrite.scheduling.RecipeRunCycle.editSources(RecipeRunCycle.java:177)
        at org.openrewrite.RecipeScheduler.runRecipeCycles(RecipeScheduler.java:84)
        at org.openrewrite.RecipeScheduler.scheduleRun(RecipeScheduler.java:41)
        at org.openrewrite.Recipe.run(Recipe.java:442)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:382)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:130)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:125)
        at org.openrewrite.groovy.ChangePackageAdaptabilityTest.fullyQualified(ChangePackageAdaptabilityTest.java:76)

        Caused by:
        org.openrewrite.internal.RecipeRunException: java.lang.StringIndexOutOfBoundsException: Range [0, -1) out of bounds for length 11
            at app//org.openrewrite.TreeVisitor.visit(TreeVisitor.java:278)
            at app//org.openrewrite.TreeVisitor.visit(TreeVisitor.java:154)
            at app//org.openrewrite.java.ChangePackage$2.preVisit(ChangePackage.java:141)
            at app//org.openrewrite.java.ChangePackage$2.preVisit(ChangePackage.java:131)
            at app//org.openrewrite.TreeVisitor.visit(TreeVisitor.java:239)
            at app//org.openrewrite.TreeVisitor.visit(TreeVisitor.java:154)
            at app//org.openrewrite.Preconditions$Check.visit(Preconditions.java:175)
            at app//org.openrewrite.Preconditions$Check.visit(Preconditions.java:145)
            at app//org.openrewrite.scheduling.RecipeRunCycle.lambda$editSources$7(RecipeRunCycle.java:210)
            at app//org.openrewrite.scheduling.RecipeRunCycle$$Lambda/0x00007f1f243b9be8.call(Unknown Source)
            at app//io.micrometer.core.instrument.AbstractTimer.recordCallable(AbstractTimer.java:147)
            at app//org.openrewrite.table.RecipeRunStats.recordEdit(RecipeRunStats.java:74)
            at app//org.openrewrite.scheduling.RecipeRunCycle.lambda$editSources$8(RecipeRunCycle.java:206)
            ... 18 more

            Caused by:
            java.lang.StringIndexOutOfBoundsException: Range [0, -1) out of bounds for length 11
                at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
                at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
                at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
                at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
                at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
                at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckFromToIndex(Preconditions.java:112)
                at java.base/jdk.internal.util.Preconditions.checkFromToIndex(Preconditions.java:349)
                at java.base/java.lang.String.checkBoundsBeginEnd(String.java:4865)
                at java.base/java.lang.String.substring(String.java:2834)
                at org.openrewrite.java.ChangePackage$JavaChangePackageVisitor.postVisit(ChangePackage.java:263)
                at org.openrewrite.java.ChangePackage$JavaChangePackageVisitor.postVisit(ChangePackage.java:158)
                at org.openrewrite.TreeVisitor.visit(TreeVisitor.java:245)
                ... 30 more

ChangePackageAdaptabilityTest > changeDefinition() FAILED
    org.opentest4j.AssertionFailedError: 
    expected: "x/y/z/Test.groovy"
     but was: "org/foo/Test.groovy"
        at app//org.openrewrite.groovy.ChangePackageAdaptabilityTest.lambda$changeDefinition$4(ChangePackageAdaptabilityTest.java:143)
        at app//org.openrewrite.groovy.ChangePackageAdaptabilityTest$$Lambda/0x00007f1f245213d8.accept0(Unknown Source)
        at app//org.openrewrite.internal.ThrowingConsumer.accept(ThrowingConsumer.java:26)
        at app//org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:554)
        at app//org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:130)
        at app//org.openrewrite.groovy.ChangePackageAdaptabilityTest.changeDefinition(ChangePackageAdaptabilityTest.java:129)

ChangePackageAdaptabilityTest > renamePackageRecursive() FAILED
    org.opentest4j.AssertionFailedError: 
    expected: "org/foo/test/internal/Test.groovy"
     but was: "org/foo/internal/Test.groovy"
        at app//org.openrewrite.groovy.ChangePackageAdaptabilityTest.lambda$renamePackageRecursive$1(ChangePackageAdaptabilityTest.java:119)
        at app//org.openrewrite.groovy.ChangePackageAdaptabilityTest$$Lambda/0x00007f1f2452e9d8.accept0(Unknown Source)
        at app//org.openrewrite.internal.ThrowingConsumer.accept(ThrowingConsumer.java:26)
        at app//org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:554)
        at app//org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:130)
        at app//org.openrewrite.groovy.ChangePackageAdaptabilityTest.renamePackageRecursive(ChangePackageAdaptabilityTest.java:105)

Would you mind taking a look at those? Could also be helpful to have a test that would have failed previously but now passes, just to avoid any regressions in the future.

the issue fixed, sorry for the delay

Oct 03 '25 04:10 qxo