rewrite icon indicating copy to clipboard operation
rewrite copied to clipboard

Option to add classifier to managed dependency

Open timtebeek opened this issue 2 years ago • 1 comments

What's changed?

Added @Option Boolean includeManaged to .../maven/ChangeDependencyClassifier.

What's your motivation?

Fixes #3830

Anyone you would like to review specifically?

@melloware

Have you considered any alternatives or workarounds?

Separate recipe seems too heavy-handed;

Any additional context

  • #3830

TODO

  • [ ] Only add in managed when present
  • [ ] Possibly do the same for Gradle

timtebeek avatar Dec 16 '23 18:12 timtebeek

Not quite pleased with this approach yet: ideally we detect if a dependency is managed (in a pom part of the git repository), and only then add the classifier there, without passing in an explicit option toggle. 🤔

timtebeek avatar Dec 16 '23 18:12 timtebeek

I'm going to close this attempt; the downside of having something sub-optimal is that folks will build it into their own recipes, making it hard to remove. I think instead we should opt for detecting if a dependency is managed, and if so add the classifier to the managed dependency if we can, and if we can not then add the classifier where it's used instead. I'll close this attempt for now .

timtebeek avatar Apr 30 '24 10:04 timtebeek