rewrite icon indicating copy to clipboard operation
rewrite copied to clipboard

feat: add RemoveCompileScope recipe

Open yeikel opened this issue 1 year ago • 3 comments

Closes #2888

yeikel avatar Feb 25 '23 02:02 yeikel

Github is acting up for some reason. I am trying to re-request a review from @jkschneider and @timtebeek

Thanks!

yeikel avatar Mar 05 '23 05:03 yeikel

Looking at the implementation and current set of tests my worry is if we would correctly handle cases where there is a parent with a dependencyManagement section, setting an explicit scope, that is overridden with compile in a project pom.xml. That parent can also be defined outside the current project, and might need to be resolved & evaluated.

timtebeek avatar Mar 06 '23 09:03 timtebeek

Looking at the implementation and current set of tests my worry is if we would correctly handle cases where there is a parent with a dependencyManagement section, setting an explicit scope, that is overridden with compile in a project pom.xml. That parent can also be defined outside the current project, and might need to be resolved & evaluated.

Are you aware of any other recipe that is doing this? Or is this a foundational need of rewrite?

If you can share any example that would be helpful

yeikel avatar Mar 07 '23 18:03 yeikel