rewrite-testing-frameworks icon indicating copy to clipboard operation
rewrite-testing-frameworks copied to clipboard

Add refaster recipes to simplify expected value

Open timo-abele opened this issue 1 year ago • 0 comments

What's changed?

3 simple refaster recipes added

What's your motivation?

salvaging the changes in https://github.com/openrewrite/rewrite-testing-frameworks/pull/472 adding missing transformations I noticed.

Anything in particular you'd like reviewers to focus on?

These recipes are simpler that the ones in https://github.com/openrewrite/rewrite-testing-frameworks/pull/472: they don't need generics and should work in Java 8. But each test yields:

Recipe was expected to make a change but made no changes.

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

SimplifyChainedAssertJAssertion could probably be extended to cover these cases, but I think refaster is the appropriate level of complexity

Any additional context

Checklist

  • [ ] I've added unit tests to cover both positive and negative cases
  • [ ] I've read and applied the recipe conventions and best practices
  • [ ] I've used the IntelliJ IDEA auto-formatter on affected files

timo-abele avatar Feb 06 '24 23:02 timo-abele