rewrite-static-analysis icon indicating copy to clipboard operation
rewrite-static-analysis copied to clipboard

org.openrewrite.staticanalysis.ReplaceDuplicateStringLiterals creates unnecessary duplicates

Open blipper opened this issue 4 months ago • 1 comments

What is the smallest, simplest way to reproduce the problem?

class A {
  public static final Map<String, String> test = Map.of("Android");
  public static final String ANDROID = "Android";
  void foo() {
   System.out.println("Android");
   }
}

What did you expect to see?

class A {
  public static final String ANDROID = "Android";
  public static final Map<String, String> test = Map.of(ANROID);
  void foo() {
   System.out.println(ANDROID);
   }
}

What did you see instead?

class A {
  private static final String ANDROID_1 = "Android";
  public static final Map<String, String> test = Map.of(ANROID_1);
  public static final String ANDROID = ANROID_1;
  void foo() {
   System.out.println(ANDROID);
   }
}

What is the full stack trace of any errors you encountered?

stacktrace output here

Are you interested in contributing a fix to OpenRewrite?

blipper avatar Oct 02 '24 21:10 blipper