rewrite-migrate-java
rewrite-migrate-java copied to clipboard
feat: normalize effective getter methods
What's changed?
Adds recipe that renames "effective getter methods" to the way lombok would name them.
What's your motivation?
When a team starts without lombok, their getter and setter methods will over time stop adhering to the way lombok names them. Maybe the team never followed the lombok naming, maybe fields got renamed but not their getter methods. Maybe previously more complex methods morph into just being just getters but keep their old name...
This recipe will normalize those methods names, so the converter can find them.
This is a separate recipe on purpose. Reasons:
- due to the edge cases listed in the recipe, it makes sense to split functionality to keep things simple.
- maybe some recipes follow a different naming convention on purpose. This recipe will make it easy to spot these cases which might be overlooked in the many changes of one big fuzzy recipe
- if a user only wants to convert lombok naming compliant getters and not rename any recipes, separate recipes make that possible
Anything in particular you'd like reviewers to focus on?
Please evaluate the edge cases. I've estimated that the effort needed to cover them is not worth it, but maybe you can see a way.
Also, I overloaded a method in LombokUtils with the original version. Maybe the methods can be merged?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist
- [ ] I've added unit tests to cover both positive and negative cases
- [ ] I've read and applied the recipe conventions and best practices
- [ ] I've used the IntelliJ IDEA auto-formatter on affected files