openreview-py icon indicating copy to clipboard operation
openreview-py copied to clipboard

Recruitment: avoid duplicates when emails replaced by profile IDs

Open celestemartinez opened this issue 3 years ago • 5 comments

Another venue had the issue of a user being added twice to the reviewer group, since reviewer accepted invitation again after emails were replaced by profile ids.

celestemartinez avatar Aug 27 '21 15:08 celestemartinez

I wonder if this should be handled in the backend instead of openreview-py

carlosmondra avatar Aug 27 '21 15:08 carlosmondra

I would prefer to not, it can be too expensive to check transitive members.

I think this can be fixed in the process function? before adding the member of the group we can check if they are already members, right?

melisabok avatar Aug 27 '21 16:08 melisabok

Another option, as @carlosmondra suggests is, the call PUT /groups/members can have a parameter to check the transitive members or not.

melisabok avatar Aug 27 '21 16:08 melisabok

There's already an issue for adding members to groups: https://github.com/openreview/openreview/issues/1661 Maybe I can make a PR that fixes both these issues

carlosmondra avatar Aug 27 '21 17:08 carlosmondra

is it possible that when the user accepts the invitation we should add the profile.id as member instead of the email address?

melisabok avatar Jun 02 '22 18:06 melisabok