openreview-py icon indicating copy to clipboard operation
openreview-py copied to clipboard

ARR Previous URL field renders incorrectly

Open cryptexcode opened this issue 1 year ago • 3 comments
trafficstars

For the re-submissions, when the submission page shows the previous url field, the url renders incorrectly. For example, image

The URL should be openreview.net/forum?id=QIWLLEs8My, not //forum/?id=QIWLLEs8My

cryptexcode avatar Jul 02 '24 18:07 cryptexcode

it seems the user entered the url with double /:

https://api2.openreview.net/notes?id=eMUKOywNK3

The regex that validates this value should be fine: https://github.com/openreview/openreview-py/blob/master/openreview/stages/arr_content.py#L201

@celestemartinez was this submission posted before the validation was enabled?

melisabok avatar Jul 02 '24 18:07 melisabok

It looks like the validation was not used for the June cycle. I am checking why the submisison invitation was not updated to include this validation once this was deployed.

celestemartinez avatar Jul 03 '24 19:07 celestemartinez

it looks like ARR is using another pre process validation: https://github.com/openreview/openreview-py/blob/master/openreview/arr/process/submission_preprocess.py

@haroldrubio can you update it with the version located here? https://github.com/openreview/openreview-py/blob/master/openreview/venue/process/submission_commitments_preprocess.py

melisabok avatar Jul 03 '24 21:07 melisabok