openreview-py icon indicating copy to clipboard operation
openreview-py copied to clipboard

Decision notifications: Update message posted to request form

Open celestemartinez opened this issue 10 months ago • 3 comments

We removed the parentGroup when email authors about decisions, so we need to update the comment posted to the request form, as this is confusing to PCs.

Screen Shot 2024-04-08 at 12 10 17 PM

celestemartinez avatar Apr 08 '24 16:04 celestemartinez

Is there a reason why we removed the parentGroup?

I don't think there is another way to check if the messages were sent.

melisabok avatar Apr 09 '24 01:04 melisabok

Is there a reason why we removed the parentGroup?

According to this to be more efficient

Maybe we just remove this text because PCs are getting confused when they follow the link and see no emails.

celestemartinez avatar Apr 09 '24 14:04 celestemartinez

Ohhhh I remember now. I would add it back, once we add the invitation id, the API doesn't validate by parentGroup anymore so it should be efficient.

melisabok avatar Apr 09 '24 19:04 melisabok

@celestemartinez is there a reason why the post_decision_stage runs with the super user permissions? I would like to use the token of the PCs to make changes in the submissions and send messages.

melisabok avatar Apr 10 '24 13:04 melisabok

I'm reverting my change: https://github.com/openreview/openreview-py/pull/2086 and hoping that a large conference uses the message invitation to send the emails.

melisabok avatar Apr 10 '24 13:04 melisabok

@celestemartinez is there a reason why the post_decision_stage runs with the super user permissions? I would like to use the token of the PCs to make changes in the submissions and send messages.

Not sure, we can probably change this. Does this mean changing the Post_Decision_Stage signatures in the request form? Would this be changed to be the venue id or the PC group id?

celestemartinez avatar Apr 10 '24 14:04 celestemartinez

I'm realizing that all the stages have the super user as signature :(

For the new venue management we need to make sure we don't use the super user to run venue workflows. We should use the super user to deploy the venue only.

Closing the issue because we are reverting my previous change.

melisabok avatar Apr 10 '24 14:04 melisabok