openreview-py icon indicating copy to clipboard operation
openreview-py copied to clipboard

Chat feature: enable chat in the venue request form

Open melisabok opened this issue 1 year ago • 3 comments

melisabok avatar Feb 22 '24 21:02 melisabok

@melisabok can you share the invitation configuration you were using with items that was causing the error?

zbialecki avatar Feb 27 '24 14:02 zbialecki

@zbialecki I pushed a change using items, I kept the line to use enum in case you need it.

melisabok avatar Feb 27 '24 19:02 melisabok

Some issues I'm seeing with the tests:

  • when the ICML tests finishes there are 3 tabs again, including an "All" tab
  • If I'm logged in as a reviewer I can't delete my own chats

zbialecki avatar Mar 08 '24 15:03 zbialecki

comittee should be changed to committee in the test too. I can add the suggestions here but it might be easier to fix them all at once and then push that change?

celestemartinez avatar May 07 '24 18:05 celestemartinez

@melisabok I think the tests need to be changed too here: comittee --> committee

celestemartinez avatar May 07 '24 19:05 celestemartinez

ok, I will change it

melisabok avatar May 07 '24 19:05 melisabok

I tested disabling and enabling the chat via the comment stage and it's working.

zbialecki avatar May 07 '24 20:05 zbialecki

Email notifications are sent, 1 email every 5 new comments or 1 email every 4 hours

What happens if there are no new comments after 4 hours? Is an email still sent?

I also think that it's not necessary to send 1 email every 5 comments. I think that sending 1 email every 4 hours if there are any new messages is enough.

carlosmondra avatar May 07 '24 21:05 carlosmondra

What happens if there are no new comments after 4 hours? Is an email still sent?

no emails are sent if there are no new comments since the last_notified_comment_id.

melisabok avatar May 07 '24 21:05 melisabok

I also think that it's not necessary to send 1 email every 5 comments. I think that sending 1 email every 4 hours if there are any new messages is enough.

I'm worried that could be too many messages in 4 hours and the participants won't get any notifications.

melisabok avatar May 07 '24 21:05 melisabok