openreview-py
openreview-py copied to clipboard
Chat feature: enable chat in the venue request form
@melisabok can you share the invitation configuration you were using with items
that was causing the error?
@zbialecki I pushed a change using items, I kept the line to use enum in case you need it.
Some issues I'm seeing with the tests:
- when the ICML tests finishes there are 3 tabs again, including an "All" tab
- If I'm logged in as a reviewer I can't delete my own chats
comittee
should be changed to committee
in the test too. I can add the suggestions here but it might be easier to fix them all at once and then push that change?
@melisabok I think the tests need to be changed too here: comittee
--> committee
ok, I will change it
I tested disabling and enabling the chat via the comment stage and it's working.
Email notifications are sent, 1 email every 5 new comments or 1 email every 4 hours
What happens if there are no new comments after 4 hours? Is an email still sent?
I also think that it's not necessary to send 1 email every 5 comments. I think that sending 1 email every 4 hours if there are any new messages is enough.
What happens if there are no new comments after 4 hours? Is an email still sent?
no emails are sent if there are no new comments since the last_notified_comment_id.
I also think that it's not necessary to send 1 email every 5 comments. I think that sending 1 email every 4 hours if there are any new messages is enough.
I'm worried that could be too many messages in 4 hours and the participants won't get any notifications.