openreview-py icon indicating copy to clipboard operation
openreview-py copied to clipboard

Adds SACs as AC group writers

Open purujitgoyal opened this issue 3 years ago • 4 comments

purujitgoyal avatar Jul 19 '22 19:07 purujitgoyal

Codecov Report

Merging #1353 (f87bee8) into master (57e3bc8) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1353   +/-   ##
=======================================
  Coverage   72.10%   72.10%           
=======================================
  Files          26       26           
  Lines        8260     8260           
  Branches     1478     1478           
=======================================
  Hits         5956     5956           
  Misses       1932     1932           
  Partials      372      372           
Impacted Files Coverage Δ
openreview/conference/builder.py 80.16% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

codecov[bot] avatar Jul 19 '22 21:07 codecov[bot]

@nlbahy please confirm but I think the assigned SAC needs to be writer of the assigned AC group, right? not the general AC group.

melisabok avatar Jul 26 '22 19:07 melisabok

@nlbahy please confirm but I think the assigned SAC needs to be writer of the assigned AC group, right? not the general AC group.

I have been fixing this by adding the overall SAC group as writers of the overall AC group, but technically this would allow SACs to edit the AC group. So it is probably safer to add each paper SAC as a writer of each paper AC.

nlbahy avatar Jul 26 '22 19:07 nlbahy

I'm nervous that SAC users can edit the AC group :/

melisabok avatar Jul 26 '22 20:07 melisabok

Fixed it in the API 2

melisabok avatar May 03 '23 21:05 melisabok