Add max note count as option for the bid stage

[carlosmondra]

[codecov[bot]]

Codecov Report

Merging #1007 (b91d123) into master (cf96cfc) will increase coverage by 5.32%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
+ Coverage   74.83%   80.16%   +5.32%     
==========================================
  Files          19       19              
  Lines        5139     5142       +3     
  Branches      874      875       +1     
==========================================
+ Hits         3846     4122     +276     
+ Misses       1033      773     -260     
+ Partials      260      247      -13     

Impacted Files	Coverage Δ
openreview/conference/webfield.py	95.11% <0.00%> (+1.99%)	:arrow_up:
openreview/conference/builder.py	85.48% <100.00%> (+2.98%)	:arrow_up:
openreview/conference/matching.py	92.03% <0.00%> (+1.01%)	:arrow_up:
openreview/openreview.py	74.78% <0.00%> (+3.01%)	:arrow_up:
openreview/conference/helpers.py	36.79% <0.00%> (+3.03%)	:arrow_up:
openreview/conference/invitation.py	93.25% <0.00%> (+3.22%)	:arrow_up:
openreview/tools.py	58.89% <0.00%> (+13.86%)	:arrow_up:
openreview/venue_request/venue_request.py	94.33% <0.00%> (+74.52%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cf96cfc...b91d123. Read the comment docs.

[melisabok]

You could the max_count in the venue request form so the PCs can decide if they want to limit it or not:

https://github.com/openreview/openreview-py/blob/master/openreview/venue_request/venue_request.py#L63

[carlosmondra]

I realized that this does not work and I have not had the time to really fix it.

[melisabok]

Ok, I can assign it to somewhere else.

Sometimes venues ask for this.

[carlosmondra]

Ok, I can assign it to somewhere else.

Sometimes venues ask for this.

Yes, if this is something we want soon, it'd be better is someone else works on this.

[melisabok]

@carlosmondra , can @xkopenreview add this feature to the new react bidding console? should we wait until we have a first version and add this later?

[carlosmondra]

@carlosmondra , can @xkopenreview add this feature to the new react bidding console? should we wait until we have a first version and add this later?

I think it's fine if he can add it. I realized that my approach in this PR was wrong, he would need to fix that first. If it's too troublesome, maybe we can wait until later to implement it.

[xkopenreview]

what's the rationale of limiting the number of papers retrieved?

[melisabok]

what's the rationale of limiting the number of papers retrieved?

Some PCs don't want reviewers to see more than the top N papers. They haven't request this lately so I suggest to close this PR, agree?

[carlosmondra]

Yes, we need to rethink the approach anyway.