openreview-expertise icon indicating copy to clipboard operation
openreview-expertise copied to clipboard

Use PyTorch for New Model Embeddings

Open haroldrubio opened this issue 1 year ago • 3 comments

This PR moves more shared functions into the Predictor class, avoids moving the embeddings from GPU to CPU each batch (speeds up each iteration), uses PyTorch's .save() and .load() to store embeddings more efficiently (takes up less disk)

haroldrubio avatar Feb 26 '24 11:02 haroldrubio

it seems this only works for specter2+scinclr, can we support it for specter2+mfr too?

melisabok avatar Feb 26 '24 16:02 melisabok

It looks like MFR is already using PyTorch serialization. The original SPECTER would be pretty tough to override since it looks like it re-uses some old code from a 4 year old branch of the allennlp library, the JSON predictions are built into it

haroldrubio avatar Feb 26 '24 21:02 haroldrubio

Do we still want to merge this?

carlosmondra avatar Aug 26 '24 20:08 carlosmondra