stream-echo-nginx-module icon indicating copy to clipboard operation
stream-echo-nginx-module copied to clipboard

tests fail on 1.11.2

Open chipitsine opened this issue 8 years ago • 2 comments

https://travis-ci.org/chipitsine/stream-echo-nginx-module

I wondered, how valgrind could help. It seems, it noisy, some findings should be muted. but it didn't give a clue on what's going on

chipitsine avatar Nov 14 '16 04:11 chipitsine

@chipitsine Your valgrind setup is not right hence those false positives. See below for more details:

https://openresty.gitbooks.io/programming-openresty/content/testing/test-modes.html#_valgrind_mode

agentzh avatar Nov 14 '16 22:11 agentzh

@chipitsine The following test failures are known when using nginx 1.11.2:

t/discard-req.t ...... 23/48
#   Failed test 'TEST 2: discard request before simple single echo (with request) - response_body - response is expected (repeated req 0, req 0)'
#   at /home/agentzh/git/stream-echo-nginx-module/../test-nginx/lib/Test/Nginx/Socket.pm line 1382.
#          got: 'receive stream response error: connection reset by peer
# '
#     expected: 'Hello, stream echo!
# '

#   Failed test 'TEST 2: discard request before simple single echo (with request) - pattern "[error]" should not match any line in error.log but matches line "2016/11/14 14:47:50 [error] 57872\#57872: *1 recv() failed (104: Connection reset by peer), client: 127.0.0.1, server: localhost, request: \"GET /t HTTP/1.1\", host: \"localhost\"" (req 0)'
#   at /home/agentzh/git/stream-echo-nginx-module/../test-nginx/lib/Test/Nginx/Socket.pm line 1201.

#   Failed test 'TEST 2: discard request before simple single echo (with request) - response_body - response is expected (repeated req 1, req 0)'
#   at /home/agentzh/git/stream-echo-nginx-module/../test-nginx/lib/Test/Nginx/Socket.pm line 1382.
#          got: 'receive stream response error: connection reset by peer
# '
#     expected: 'Hello, stream echo!
# '

#   Failed test 'TEST 2: discard request before simple single echo (with request) - pattern "[error]" should not match any line in error.log but matches line "2016/11/14 14:47:50 [error] 57872\#57872: *4 recv() failed (104: Connection reset by peer), client: 127.0.0.1, server: localhost, request: \"GET /t HTTP/1.1\", host: \"localhost\"" (req 1)'
#   at /home/agentzh/git/stream-echo-nginx-module/../test-nginx/lib/Test/Nginx/Socket.pm line 1201.

#   Failed test 'TEST 6: discard then read line - response_body - like (repeated req 0, req 0)'
#   at /home/agentzh/git/stream-echo-nginx-module/../test-nginx/lib/Test/Nginx/Socket.pm line 1379.
#                   'receive stream response error: connection reset by peer
# '
#     doesn't match '(?^s:^(?:send stream request error: broken pipe)?$)'

#   Failed test 'TEST 6: discard then read line - response_body - like (repeated req 1, req 0)'
#   at /home/agentzh/git/stream-echo-nginx-module/../test-nginx/lib/Test/Nginx/Socket.pm line 1379.
#                   'receive stream response error: connection reset by peer
# '
#     doesn't match '(?^s:^(?:send stream request error: broken pipe)?$)'

#   Failed test 'TEST 4: discard then read bytes - response_body - like (repeated req 0, req 0)'
#   at /home/agentzh/git/stream-echo-nginx-module/../test-nginx/lib/Test/Nginx/Socket.pm line 1379.
#                   'receive stream response error: connection reset by peer
# '
#     doesn't match '(?^s:^(?:send stream request error: broken pipe)?$)'

#   Failed test 'TEST 4: discard then read bytes - response_body - like (repeated req 1, req 0)'
#   at /home/agentzh/git/stream-echo-nginx-module/../test-nginx/lib/Test/Nginx/Socket.pm line 1379.
#                   'receive stream response error: connection reset by peer
# '
#     doesn't match '(?^s:^(?:send stream request error: broken pipe)?$)'
# Looks like you failed 8 tests of 48.
t/discard-req.t ...... Dubious, test returned 8 (wstat 2048, 0x800)
Failed 8/48 subtests

These are not memory issues so valgrind won't find anything (it is still valgrind clean on my side).

agentzh avatar Nov 14 '16 22:11 agentzh