sregex icon indicating copy to clipboard operation
sregex copied to clipboard

silence warning about if guard

Open maage opened this issue 9 years ago • 1 comments

gcc 6.1.1 has this warning at Fedora 24. I'm not quite sure how to fix this right, now patch does fixes the warning and it should do as previously. So this should be just style without functional change.

In file included from src/sregex/sre_vm_thompson_jit.c:16:0:
./dynasm/dasm_x86.h: In function 'dasm_put':
./dynasm/dasm_x86.h:207:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
  if (*p++ == 1 && *p == DASM_DISP) mrm = n; continue;
  ^~
./dynasm/dasm_x86.h:207:45: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
  if (*p++ == 1 && *p == DASM_DISP) mrm = n; continue;
                                             ^~~~~~~~

maage avatar Aug 03 '16 13:08 maage

@maage Maybe we should update the upstream dynasm instead? We simply copied over the dynasm directory of the luajit-2.0 git repository BTW.

agentzh avatar Aug 04 '16 18:08 agentzh