lua-resty-mysql icon indicating copy to clipboard operation
lua-resty-mysql copied to clipboard

why not call sock::close when read timeout like redis.lua did?

Open yyqbuct opened this issue 7 years ago • 1 comments

why not call sock::close when read timeout like redis.lua did?

In redis.lua,the connection pool was destroyed when read timeout happens

SHA-1: c75af8fe7f71ca05e4bd3ccb3923f6a81d62a67a bugfix: the memcached connection might enter a bad state when read timeout happens because ngx_lua's cosocket reading calls no longer automatically close the connection in this case.

so my question is why did not treat this as a bug in mysql.lua

thanks

yyqbuct avatar Jan 18 '18 06:01 yyqbuct

@yyqbuct Seems like we need to port that fix over too. Pull requests welcome!

agentzh avatar Jan 19 '18 20:01 agentzh