drizzle-nginx-module icon indicating copy to clipboard operation
drizzle-nginx-module copied to clipboard

HTTP/2 supporting

Open boyxuper opened this issue 8 years ago • 6 comments

Since lua_nginx_module been support HTTP/2: openresty/lua-nginx-module#566 Is there any chance we could also get drizzle-nginx-module to work with HTTP/2 ?

boyxuper avatar Apr 09 '16 02:04 boyxuper

@boyxuper You should try it out yourself. I think it should just work. I've never tested it though.

agentzh avatar Apr 09 '16 05:04 agentzh

@boyxuper BTW, ngx_lua does not fully support HTTP/2 yet.

agentzh avatar Apr 09 '16 05:04 agentzh

@agentzh Thx for the fast reply. I've tried drizzle with HTTP/2 but failed, and here's the error log:

2016/04/10 02:23:11 [alert] 5834#0: *436835 epoll_ctl(1, 43) failed (17: File exists), client: 127.0.0.1, server: , request: "GET /item/245136127 HTTP/2.0", subrequest: "/_read_mysql", host: "127.0.0.1"

I'm afraid that I'm not so familiar with drizzle-nginx-module code, but I'd like to try, what should I do to fix this?

boyxuper avatar Apr 09 '16 18:04 boyxuper

@boyxuper I guess we should migrate the following two code snippets guarded by NGX_HTTP_V2 in src/http/ngx_http_upstream.c of the latest NGINX core to ngx_drizzle's src/ngx_http_drizzle_upstream.c file:

src/http/ngx_http_upstream.c
490:#if (NGX_HTTP_V2)
1176:#if (NGX_HTTP_V2)

agentzh avatar Apr 10 '16 03:04 agentzh

@boyxuper @agentzh https://github.com/openresty/lua-nginx-module/issues/252#issuecomment-24369065 I'm not sure if this is related.

jmealo avatar Apr 21 '16 11:04 jmealo

@jmealo Yeah, the error message is similar. But I cannot derive more from just the error message itself. Patches welcome :)

agentzh avatar Apr 26 '16 20:04 agentzh