docker-openresty icon indicating copy to clipboard operation
docker-openresty copied to clipboard

Request : Add docker-entrypoint.sh provided in the nginx image, so that environment variables can be used in the configuration

Open omasseau opened this issue 3 years ago • 4 comments

It would be nice to add in the image the docker-entrypoint.sh file and the docker-entrypoint.d folder which are provided in the nginx official image and add it as an ENTRYPOINT of the openresty image:

ENTRYPOINT ["/docker-entrypoint.sh"]

(see : https://github.com/nginxinc/docker-nginx/blob/f958fbacada447737319e979db45a1da49123142/mainline/debian/Dockerfile)

This will allow to use environnement variables in the configuration as described here : https://github.com/docker-library/docs/tree/master/nginx#using-environment-variables-in-nginx-configuration-new-in-119 :)

Note that docker-entrypoint.sh may have to be adapted to support the "/usr/bin/openresty" command:

if [ "$1" = "nginx" -o "$1" = "nginx-debug" ]; then

-->

if [ "$1" = "/usr/bin/openresty"]; then

omasseau avatar Jul 21 '21 10:07 omasseau

I could see how that is useful. I don't have time to work on this myself, but would check out PRs.

neomantra avatar Aug 03 '21 15:08 neomantra

I could see how that is useful. I don't have time to work on this myself, but would check out PRs.

rly? it 5 min copy-paste ( okay, i did it.. local xD

korokunt avatar Oct 13 '21 11:10 korokunt

Great, then make a complete and tested PR rather than a useless comment.

neomantra avatar Oct 13 '21 12:10 neomantra

I have kind of implemented this in my modsecurity-packaged version. I am only building the alpine-fat version currently though. I will look into this, maybe I can help.

TafkaMax avatar Jan 05 '24 16:01 TafkaMax