openrazer
openrazer copied to clipboard
openrazer
Add Support for Razer Ornata V3 (02A1 & 028F)
This adds support for the Razer Ornata V3, finalizing the bulk of the work from #1940.
With adaptions from the PR, I noticed that the static and spectrum modes turn off on a key press only when the reactive effect was set at least once beforehand. Upon replugging the keyboard while persistently configured to display the static effect, the issue does not occur so long as the effect is not switched to reactive at any point when it is plugged in. This behavior is even consistent across replugs and seems to have been missed in the linked PR.
Since deeming that the reactive effect is an issue for the OV3, I figure it can be removed from its supported effects for now until further work addresses it.
All remaining effects, including brightness and colors, were tested and confirmed to be working/displaying properly on a RZ03-04460200-R3U1 (PID 02A1) Ornata V3 keyboard.
Fixes #1925, fixes #2053
I have this keyboard and am waiting for support. I don't know the full workflow for this repository, but is there anything I can do to support getting this merged and ultimately end up in Ubuntu's package manager?
@tulser that's awesome and thanks for the efforts.
To the maintainers, can this be merged?
@z3ntu, when you can, could you please review this PR? Aside from lacking explicit confirmation(s) that it works for the keyboards with PID 028f, it should be ready to be merged.
Hello all
I have tested this and works fine on my Ornata v3 with PID 028F with some quirks When changing modes I have weird logs in dmesg
[ 174.559183] razerkbd: Response doesn't match request. status: 02 transaction_id.id: 1f remaining_packets: 00 protocol_type: 00 data_size: 06, command_class: 0f, command_id.id: 02 Params: 01050401280000000000000000000000 . [ 179.676492] razer driver: Device data transfer failed. [ 179.684421] razerkbd: Response doesn't match request. status: 02 transaction_id.id: 1f remaining_packets: 00 protocol_type: 00 data_size: 09, command_class: 0f, command_id.id: 02 Params: 01050100000100ff0000000000000000 . [ 191.447602] razer driver: Device data transfer failed. [ 191.454897] razerkbd: Response doesn't match request. status: 02 transaction_id.id: 1f remaining_packets: 00 protocol_type: 00 data_size: 09, command_class: 0f, command_id.id: 02 Params: 01050201000100ff0000000000000000 . [ 204.759553] razer driver: Device data transfer failed. [ 204.767450] razerkbd: Response doesn't match request. status: 02 transaction_id.id: 1f remaining_packets: 00 protocol_type: 00 data_size: 06, command_class: 0f, command_id.id: 02 Params: 01050300000000000000000000000000 .
And GUI app (Polychromatic) freeze for a bit every time I change it (but works)
So hope this helps
@ddB0515, do you know what modes you are changing to or changing from to get those messages?
Here is video of changing it with both windows so you can see
https://github.com/openrazer/openrazer/assets/20762436/825fc612-11b7-43b4-aa46-661023bad263
Looking at your video, it seems to show correct responses, also indicating successes, despite being reported as errors. The command class and command ID fields for each message correspond to the effects you are selecting, so if you're seeing accurate effects on your keyboard then there could be issue with the communication itself seeing as the driver is receiving responses with incorrect length after some time. Could you try making a packet capture while going through some of the modes?
PR content looks sane, thanks!
So from what I understand this PR works fine for everybody except for @ddB0515 who has significant issues as shown in the video and comments above? I see @ddB0515 has the 028f keyboard, does anybody else have that one?
So from what I understand this PR works fine for everybody except for ddB0515 who has significant issues as shown in the video and comments above?
There is ambiguity about the version of keyboards people are using and whether they have tested the board with this PR, so I need to ask:
@0xGingi @aaronmboyd @rodehoed - Assuming you all have an OV3 keyboard and have built and installed/tested the driver + daemon from this PR with your keyboard, would you mind posting the product number and PID of your keyboard as well as say if you are having any other issues which may be on account of the driver or daemon in any way? I'd like to poll for anyone having any issues, including and especially those similar to the one that @ddB0515 has.
@tulser I am currently running this build with PID: 1532:02A1 (Not sure how to find the product number) with no issues or bugs
Not sure how to find the product number
@0xGingi - You should be able to find it on the label under the keyboard, it should be of a form similar to RZ03-04460200-R3U1.
So from what I understand this PR works fine for everybody except for ddB0515 who has significant issues as shown in the video and comments above?
There is ambiguity about the version of keyboards people are using and whether they have tested the board with this PR, so I need to ask:
@0xGingi @aaronmboyd @rodehoed - Assuming you all have an OV3 keyboard and have built and installed/tested the driver + daemon from this PR with your keyboard, would you mind posting the product number and PID of your keyboard as well as say if you are having any other issues which may be on account of the driver or daemon in any way? I'd like to poll for anyone having any issues, including and especially those similar to the one that @ddB0515 has.
I haven't tested, not sure of the full instructions to be honest, since I had the packaged version installed already. I was able to build using the deb from the ./scripts folder and install, but Polychromatic hasn't changed. I'm still wading through Secure boot issues too from the original install.
I was able to build using the deb from the ./scripts folder and install, but Polychromatic hasn't changed. I'm still wading through Secure boot issues too from the original install.
@aaronmboyd - For polychromatic not showing it, did you restart the (openrazer) daemon and try replugging your keyboard? Also, if you have the same product no. as I or 0xGingi, you probably don't have to spend time or trouble to test it if you don't want to.
Nothing further on the 028f keyboard(s) at the moment. I haven't been paying too much attention to this recently, but support/performance for 02a1/RZ03-04460200-R3U1 seems fine since getting another confirmation on the model.
@ddB0515: Did you ever get a pcap with your keyboard or otherwise found the issue that you were having with it?
Sorry all but I can't do it as traveling and not sure when will be home, so if I'm only one have issue ignore me and just merge as nobody else complexioned or had any issues with it Sorry that I'm not so much help right now :(
Alright, then @z3ntu, since there is at least one keyboard (model) and the one PID that works good with these changes, I'm fairly confident that other OV3 keyboard models will work fine; I'd like to say this is sufficient to merge based on that. Although the source of Dario's 028f issues with latency and errors isn't exactly identified, I figure that anything that comes up with it or with more people using 028f keyboards can be addressed down the road.
@tulser Maybe split 028F support out to a separate PR then? I think merging 02A1 and delaying the other is the most reasonable thing to do for now.
@z3ntu Yeah, I think that's a sensible thing to do. I'll make this be the 02a1 PR.
I've removed the 028f PID in this latest commit, this should ready for review or merging.
Also please open a PR for 028F after, would be good to get this in maybe after some more testing or whatever.