xradar icon indicating copy to clipboard operation
xradar copied to clipboard

Combine radar sweeps into a logical radar volume.

Open egouden opened this issue 3 months ago • 4 comments

This is useful for stacking single sweeps or creating a new volume logic based on time.

egouden avatar Oct 02 '25 12:10 egouden

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 93.58%. Comparing base (6496432) to head (2793eb1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   93.52%   93.58%   +0.06%     
==========================================
  Files          27       27              
  Lines        5572     5613      +41     
==========================================
+ Hits         5211     5253      +42     
+ Misses        361      360       -1     
Flag Coverage Δ
notebooktests 0.00% <0.00%> (ø)
unittests 93.58% <100.00%> (+0.06%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 02 '25 13:10 codecov[bot]

I added the option to select sweeps by angle. This is useful if you want to discard a calibration scan (i.e. 90 degree).

egouden avatar Oct 09 '25 08:10 egouden

@kmuehlbauer

I found inconsistencies in the global variable sweep_group_name. Should it be a list of strings or ints? Most readers return ints but cfradial1 reader returns strings. There is also a conversion in the global metadata constructor.

I think the string is better because it is consistent with the variable name and you can use it directly for accessing the sweeps. I guess this has no negative impact on the performance.

egouden avatar Oct 09 '25 09:10 egouden

np.datetime64 is now used internally to avoid local time issues

egouden avatar Oct 13 '25 10:10 egouden