qe-compiler icon indicating copy to clipboard operation
qe-compiler copied to clipboard

Add patch from upstream LLVM to fix ssa value names for long integer constants

Open mhillenbrand opened this issue 2 years ago • 1 comments

For constant ops from arithmetic constants, MLIR chooses SSA value names that reflect the constant. That failed for ints with > 64 bits as the function that derived that name used a shortcut that did not apply (and assert(), as here) for ints with more than 64 bits.

We have contributed a fix to upstream LLVM in https://github.com/llvm/llvm-project/commit/1ef32e78284bc758112632e9e190b6683ea5b95b and need to add this patch into our build of LLVM 14.0.6. (the fix will be included in LLVM 15).

Surfaced by #43

mhillenbrand avatar Feb 14 '23 10:02 mhillenbrand

How is the CI passing? Locally, check-tests fails with current main (c941dd9536d9febedeae6351381e17c860110f8f).

vrpascuzzi avatar Feb 18 '23 04:02 vrpascuzzi