tarball releases do not include version number

[daavve]

Hi,

The version numbers are only generated when you run build inside a git repository:

The makefile gets the version information by running a git command:

${VERSION_FILE}: echo -n "#define INTERNAL_PILLOWFIGHT_VERSION \"" >| $@ echo -n $(shell git describe --always) >> $@ echo "\"" >> $@ Since the tarball does not include the git repository the above command fails and _version.h ends up with the following:

#define INTERNAL_PILLOWFIGHT_VERSION "" Python then records the version as 0.0.0

I do not know a way to fix this without adding a a duplicate version number to the Makefile. Maybe github provides some hook you can use to automatically include the release number inside the Makefile at release

-Dave

[jflesch]

I must admit, I didn't think of this one .. :/

I assume this is for packaging purpose ? Is it possible for you to just add a _version.h manually before compiling ?

[jflesch]

If you're interested only in the Python version, another solution is to use the package from Pypi. This one already includes a _version.h.

[daavve]

Thank you for the quick response, I run Arch Linux, and use the AUR version of pypillowfight.

For reasons I do not fully understand python packages in Arch Linux are usually downloaded directly from the upstream project rather from pypi.

I like your idea of manually adding the 'version.h' file. While I do maintain some AUR packages I do not maintain the python-pypillowfight package, so I cannot implement any of these changes directly.

I reported this issue to the python-pypillowfight maintainer. Hopefully he/she will get in touch with you on this.

-Dave

[StreakyCobra]

Hi @daavve. I had kind of the same problem with the tarball when trying to use the new build system, as I initially reported here. Then I switched to the git source directly instead of the tarball and the problem went away, at least on my computer for the python part.

While I do maintain some AUR packages I do not maintain the python-pypillowfight package, so I cannot implement any of these changes directly.

As proposed in #17, for the reasons mentioned there too (no motivation about the C part of pillowfight), I'm ready to transfer the ownership of pillowfight in AUR if someone (you?) is interested by it :wink: