visualisation-tool icon indicating copy to clipboard operation
visualisation-tool copied to clipboard

Statement property pop-up for indirect edges centred on whole diagram and not on the edge in question

Open StephenAbbott opened this issue 1 year ago • 2 comments

Describe the bug When testing example data including https://github.com/openownership/data-standard/blob/main/examples/mixed-direct-and-indirect-ownership.json and https://github.com/openownership/data-standard/blob/main/examples/multiple-indirect-ownership.json, the statement property pop-ups for most of the nodes and edges appear centred on the node/edge which the user has clicked on.

But with the indirect edges appearing at the bottom of the diagram for each of these two examples, clicking on that edge makes the pop-up window appear in the middle of the diagram rather than over the middle of the edge in question.

To Reproduce Steps to reproduce the behavior:

  1. Paste this JSON into the visualiser tool and click 'Draw'
  2. Click on the owns 60% indirect edge going from Person 1 to Company B
  3. The statement property pop-up window should appear but is centred in the middle of the whole diagram not in the middle of the edge in question (see image below)

Expected behavior The statement property pop-up window should appear centred on the middle of the edge the user has clicked rather than the middle of the whole diagram

Screenshots Image

Desktop (please complete the following information):

  • OS: iOS
  • Browser: Chrome
  • Version: 130.0.6723.117 (Official Build) (arm64)

StephenAbbott avatar Dec 06 '24 14:12 StephenAbbott

The reason this happens is that it uses the bounding box of the edge clicked, so in this example it uses the upper-most edge (i.e. where the edge curves upwards) as the top of the edge and places the tooltip there:

Image

To fix this will likely involve storing the mouse (or touch) position at the point of interaction and setting the tooltip's coordinates to that.

codemacabre avatar Dec 10 '24 09:12 codemacabre

@codemacabre Thanks for the response. This isn't a high-priority issue to fix so let's leave on the backlog for now

StephenAbbott avatar Dec 11 '24 22:12 StephenAbbott