visualisation-tool icon indicating copy to clipboard operation
visualisation-tool copied to clipboard

Bug: blank png downloaded alongside correct png each time 'Download PNG' is clicked

Open StephenAbbott opened this issue 1 year ago • 6 comments

During testing using the BODS Data Visualisation Demo version, I am experiencing a bug where the diagram is generated correctly - but when I click 'Download png', it downloads a blank file called bods.png and then a correct second png is downloaded called bods (1).png.

See example pngs generated using mixed-direct-and-indirect-ownership.json: Image Image

I carried out tests using the following two BODS version 0.4 JSON example files: mixed-direct-and-indirect-ownership.json fermcat (1).json

I'm on a MacBook Pro running 14.6.1 MacOS Sonoma using Chrome Version 129.0.6668.100 (Official Build) (arm64).

StephenAbbott avatar Oct 15 '24 15:10 StephenAbbott

When I try to recreate this issue, what happens is that on clicking the 'Download PNG' button, two dialog boxes open (to save the image to my machine). I'm on Ubuntu 20, Firefox 131

kd-ods avatar Oct 16 '24 15:10 kd-ods

I was able to recreate the bug as follows: OS: MacOS Big Sur version 11.6, chip M1 2020 Browsers: Version 129.0.6668.100 (Official Build) (arm64) & Safari Version 14.1.2 (16611.3.10.1.6)

  • First attempt to download the PNG, only one file is downloaded, as expected.
  • Without refreshing the page, if the same data is pasted, on clicking the 'Download PNG' button, 2 files are download as described in the issue.
  • Upon refreshing the page and repeating the steps, only one file is downloaded, as expected.

neelima-j avatar Oct 16 '24 16:10 neelima-j

@kd-ods @codemacabre When using the embedded BODS data visualiser today, I experienced a bug similar to this previously documented exampled bug where eight blank png files were generated alongside the one correct png file when I clicked 'Download PNG'.

I'm on a MacBook Pro running 14.6.1 MacOS Sonoma using Chrome Version 136.0.7103.93.

StephenAbbott avatar May 16 '25 09:05 StephenAbbott

@StephenAbbott - thanks for reporting this. Can you supply the JSON file which is generating the issue?

kd-ods avatar May 16 '25 11:05 kd-ods

@kd-ods I've just tested using the tecido.json example file and that works fine in terms of generating only a single png file when you click Download PNG.

But I experienced this issue when using the following example data, drawn from the UK BODS version 0.4 dataset:

waterstones_example.json

The correct png file is generated but an additional blank png is downloaded along with two almost blank png files which seem to show the corner of one of the BOVS icons.

StephenAbbott avatar May 19 '25 12:05 StephenAbbott

Confirmed as repeatable using @neelima-j 's workflow as described above. I'm on:

OS: Ubuntu 24.04 Browser: Firefox 141.0 (64-bit)

Re-opening.

kd-ods avatar Aug 05 '25 14:08 kd-ods