woeip icon indicating copy to clipboard operation
woeip copied to clipboard

Published 20 hours ago • verified publisher icon openoakland

Fix placement of error component on Upload page

Open theecrit opened this issue 3 years ago • 13 comments

Description

When uploading a single file, the error message component displays at the bottom of the screen, overlapping the footer. Still to investigate: whether this happens for just a single file upload error, or all errors/alerts.

Steps to reproduce

  1. Go to woaq.org
  2. Select "Upload" in global nav
  3. Select "upload files" or drag a single csv file to the drop zone.
  4. See error display in wrong location.

Expected behavior

The error component should display in between the drop zone and the list of uploaded file names, per the wireframes.

Screenshots

TBd

Desktop configuration

  • OS: 10.15.x
  • Browser: Firefox

Additional context

This is a holdover from when we moved to Create React App.

Affected Components (For Developers)

List what pages or backend files will need to be added, removed, or changed

Technical Resources (For Developers)

  • Figma wireframes (see "4 - File selection, 1 of each type" et al)

theecrit avatar Aug 11 '21 13:08 theecrit

Maybe look at the component order.

theecrit avatar Feb 09 '22 04:02 theecrit

I've got a fix for this but having a 403 issue when trying to push can someone help me? :)

dabryant11 avatar Mar 23 '22 22:03 dabryant11

@theecrit @TangoYankee is this a lack of permissions issue causing the 403 error?

exchrotek avatar Mar 24 '22 03:03 exchrotek

Hmm, not sure. @dabryant11, can you describe the steps you're taking that produce the 403?

theecrit avatar Mar 24 '22 11:03 theecrit

I got 403's before Jess gave me edit rights for my first PR...

On Thu, Mar 24, 2022 at 4:33 AM Jess Sand @.***> wrote:

Hmm, not sure. @dabryant11 https://github.com/dabryant11, can you describe the steps you're taking that produce the 403?

— Reply to this email directly, view it on GitHub https://github.com/openoakland/woeip/issues/357#issuecomment-1077529381, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFFW3IGNCXHZZGOBPTXIODVBRHH7ANCNFSM5B6PKAQA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

mnorelli avatar Mar 24 '22 20:03 mnorelli

Thank you all for the replies! It seems that it may a permissions issue because I created a new branch, made the fix, git add, git commit then git push and received this error Screen Shot 2022-03-24 at 4 56 58 PM @theecrit @mnorelli @exchrotek

dabryant11 avatar Mar 24 '22 23:03 dabryant11

@dabryant11 Okay, try now? I've added you as a collaborator, so hopefully that works. I can tweak permissions if needed.

theecrit avatar Mar 25 '22 17:03 theecrit

It seems like there may need to be a tweak? 😅 Screen Shot 2022-03-29 at 1 51 59 PM @theecrit

dabryant11 avatar Mar 29 '22 20:03 dabryant11

@dabryant11 Ack, sorry — you should be good now!!

theecrit avatar Mar 30 '22 01:03 theecrit

good to go and PR posted - thank you! @theecrit

dabryant11 avatar Apr 03 '22 23:04 dabryant11

Issue can be closed once we resolve/address the failing test in PR #452

theecrit avatar May 11 '22 02:05 theecrit

@theecrit seems like the only issue with testing was a warning and @gsehrlich said that this could be ignored (https://github.com/openoakland/woeip/pull/452) please confirm and if so I will merge

dabryant11 avatar May 11 '22 20:05 dabryant11

@dabryant11 The warning in drop.test.js can be ignored, but there was a new warning related to your PR that I'm not familiar with. I wouldn't recommend ignoring it

gsehrlich avatar May 11 '22 20:05 gsehrlich