opennem icon indicating copy to clipboard operation
opennem copied to clipboard

Bad gap-filling on SWIS rooftop

Open nc9 opened this issue 3 years ago • 11 comments

image

nc9 avatar Nov 15 '22 00:11 nc9

lots of data is missing and we appear to be gapfilling. image

simonhac avatar Nov 15 '22 00:11 simonhac

i think we shouldn't gapfill any solar data across 30 minute boundaries on the FE.

simonhac avatar Nov 15 '22 01:11 simonhac

@chienleng I think the FE should should none here when it's empty

I just re-ran the old APVI endpoint and it has those values again.

nc9 avatar Nov 15 '22 01:11 nc9

image image

nc9 avatar Nov 15 '22 01:11 nc9

https://twitter.com/OpenNem/status/1592334328780161024

nc9 avatar Nov 15 '22 01:11 nc9

@nc9 so APVI fixed the bad data?

a few issues i think:

  • APVI sending bad data — sh*t happens
  • APVI sending null (missing data) where they mean zero (0 MW) — should we talk to them about this?
  • our FE gap-filling over null — do we want this?

simonhac avatar Nov 15 '22 23:11 simonhac

I'll leave this open even with that patch above. The data seems to shift from underneath us - I'll collect a bit more data around this but we have more sanity checking now

APVI returns no interval timestamp for periods that are assumed to be 0 - the SQL out is casting those to 0 now

nc9 avatar Nov 18 '22 05:11 nc9

I'm going to open another issue with APVI data issues - I've got a monitoring script now and some sanity-checks

nc9 avatar Nov 24 '22 06:11 nc9

image Quite a major one from 1 Dec 4 PM through to 3 Dec 4 AM. That's some pretty bold gap-filling, I too would prefer seeing zeroes in such cases. Could do the linear gap fill only if values are on the same day for solar, and otherwise zero.

andrewbusch7 avatar Dec 05 '22 23:12 andrewbusch7

That's some pretty bold gap-filling,

I believe that is less gap-filling and more graphing the line down to the next data point

I too would prefer seeing zeroes in such cases

100% agree. I have a changeset for this weeks release for this case

nc9 avatar Dec 06 '22 21:12 nc9

https://opennem.org.au/energy/wem/?range=7d&interval=30m

We eventually got complete data from APVI but this is more about how we handle cases where it fails

nc9 avatar Dec 06 '22 23:12 nc9

@nc9 what did you actually do to fix this? the underlying cause, if i recall correctly was twofold:

  • FE interpolates when it shouldn't. did we fix this?
  • data doesn't differentiate between 0 MW and missing data.

simonhac avatar Feb 01 '23 01:02 simonhac