open.mp icon indicating copy to clipboard operation
open.mp copied to clipboard

Recursively load components

Open myudev opened this issue 10 months ago • 5 comments

Easily done QoL change for people who want to structure their components, if there's a config switch needed for whatever reason or any other reason to not do this comment kty <3

myudev avatar Apr 22 '24 20:04 myudev

Have you tested how this works with the include/exclude fields? Would doing "exclude": [ "subdir/component" ] work? What about "exclude": [ "subdir\component" ] or even "exclude": [ "subdir" ]? Same for "include".

Y-Less avatar Apr 23 '24 07:04 Y-Less

There's no include, and I believe we should rename "exclude" as well because it's not self explanatory. there is "components" to explicitly load specified components only and nothing else

AmyrAhmady avatar Apr 23 '24 07:04 AmyrAhmady

Have you tested how this works with the include/exclude fields? Would doing "exclude": [ "subdir/component" ] work? What about "exclude": [ "subdir\component" ] or even "exclude": [ "subdir" ]? Same for "include".

I kept original behaviour to not break people servers suddenly as the exclude option only checks the filename not extension or path and I couldn't find any documentation. However if wanted I could add an option to detect folder paths in exclude, so u can also exclude whole subfolders

myudev avatar Apr 23 '24 10:04 myudev

There's no include, and I believe we should rename "exclude" as well because it's not self explanatory. there is "components" to explicitly load specified components only and nothing else

"components" is the one I meant.

Y-Less avatar Apr 23 '24 12:04 Y-Less