open.mp icon indicating copy to clipboard operation
open.mp copied to clipboard

add more sanity checks config options

Open atomlin-git opened this issue 1 year ago • 5 comments

Feature #611

Made:

  • print warning, if:

    • 'enable_query' disabled, and 'announce' enabled
    • 'max_bots' >= 'max_players'
  • print error, if cant create scriptfiles folder

  • fix negative values variables (player_timeout, minimum_connection_time, messages_limit, message_hole_limit, acks_limit, limits_ban_time, weather, time)

atomlin-git avatar Mar 24 '24 15:03 atomlin-git

Thanks for implementing most of the suggested stuff! But I'd change just a couple of strings which is printed now, they are:

  1. The 'max_bots' option more or equal how 'max_players' option: "how" -> "than"
  2. Cant create 'scriptfiles' folder: "Cant create" -> "Cannot access"

NexiusTailer avatar Mar 24 '24 16:03 NexiusTailer

I think there should also be warnings for the negative options

Hual avatar Mar 29 '24 09:03 Hual

I think there should also be warnings for the negative options

my solution looks unattractive, tell me how to improve it?

image

atomlin-git avatar Mar 29 '24 18:03 atomlin-git

I think there should also be warnings for the negative options

my solution looks unattractive, tell me how to improve it?

image

It's fine, no reason to redo it if it's done already

Hual avatar Mar 31 '24 08:03 Hual

I also thought about this warning message: The 'max_bots' option more or equal than 'max_players' option. Server work can be unpredictable Basically, the behaviour is predictable, players just can't join in this case. Maybe worth noticing only about "bots option more or equal than players" as the consequences are anyway pretty obvious?

NexiusTailer avatar Mar 31 '24 13:03 NexiusTailer