add more sanity checks config options
Feature #611
Made:
-
print warning, if:
- 'enable_query' disabled, and 'announce' enabled
- 'max_bots' >= 'max_players'
-
print error, if cant create scriptfiles folder
-
fix negative values variables (player_timeout, minimum_connection_time, messages_limit, message_hole_limit, acks_limit, limits_ban_time, weather, time)
Thanks for implementing most of the suggested stuff! But I'd change just a couple of strings which is printed now, they are:
The 'max_bots' option more or equal how 'max_players' option: "how" -> "than"Cant create 'scriptfiles' folder: "Cant create" -> "Cannot access"
I think there should also be warnings for the negative options
I think there should also be warnings for the negative options
my solution looks unattractive, tell me how to improve it?
I think there should also be warnings for the negative options
my solution looks unattractive, tell me how to improve it?
It's fine, no reason to redo it if it's done already
I also thought about this warning message:
The 'max_bots' option more or equal than 'max_players' option. Server work can be unpredictable
Basically, the behaviour is predictable, players just can't join in this case. Maybe worth noticing only about "bots option more or equal than players" as the consequences are anyway pretty obvious?
