open.mp icon indicating copy to clipboard operation
open.mp copied to clipboard

Fix vehicle teleport bug and revert issue 735

Open dimmyi opened this issue 1 year ago • 3 comments

1. Forcing someone to exit spectator mode when destroying a vehicle breaks many systems.

Most admin spectator systems when a player enters a vehicle, the admin starts spectating the player's vehicle, and if some other system, for example storing the vehicle in the garage using DestroyVehicle, would force the admin to stop the mode spectator before even knowing that the player left the vehicle.

2. Stream the vehicle driver immediately to avoid the vehicle teleport bug after spectating a vehicle and have a driver. This causes the vehicle to stay in position for a moment and when the driver is StreamIn the vehicle teleports to its position.

dimmyi avatar Mar 12 '24 00:03 dimmyi

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 12 '24 00:03 CLAassistant

Does the first change now make the behaviour like in samp server?

NexiusTailer avatar Mar 12 '24 09:03 NexiusTailer

Attempting to stream the vehicle right away is indeed the right thing to do. I'm not sure about 2nd commit, we should keep player in spectating state (client will spectate nothing basically so camera will be around 0 0 0), and reset server side spectating vehicle data.

ksenonadv avatar Mar 16 '24 09:03 ksenonadv