Siemens' TWIX reader does not pass voxel dimension to MRSData object

Open darrencl opened this issue 1 year ago • 0 comments

In the TwixBuilder.build_mrsdata(), the voxel dimension does not seem to be included when constructing the object, nor returned in the parse_twix_header() method.

TwixBuilder.build_mrsdata() https://github.com/openmrslab/suspect/blob/86d3c375f5c71c363e1a443b907db13e3bfe904e/suspect/io/twix.py#L64-L70
parse_twix_header() https://github.com/openmrslab/suspect/blob/86d3c375f5c71c363e1a443b907db13e3bfe904e/suspect/io/twix.py#L284-L299

However, I can see that it is extracted here: https://github.com/openmrslab/suspect/blob/86d3c375f5c71c363e1a443b907db13e3bfe904e/suspect/io/twix.py#L179-L197

which is then used in transformation_matrix(): https://github.com/openmrslab/suspect/blob/86d3c375f5c71c363e1a443b907db13e3bfe904e/suspect/io/twix.py#L279-L282

To confirm, I compared to Siemens' DICOM reader and we can see voxel size/dimension is the last argument of https://github.com/openmrslab/suspect/blob/02fce7fece25ff06447a9ff1976be4367270aee4/suspect/io/siemens.py#L176-L181

Nov 15 '24 03:11 darrencl