openmrs-module-webservices.rest icon indicating copy to clipboard operation
openmrs-module-webservices.rest copied to clipboard

RESTWS-885: Reset password REST endpoint requires privileges

Open IamMujuziMoses opened this issue 1 year ago • 2 comments

Issue I worked on

see https://issues.openmrs.org/browse/RESTWS-885

Checklist: I completed these to help reviewers :)

  • [ ] My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • [ ] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

    No? -> execute above command

  • [ ] All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • [ ] My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

IamMujuziMoses avatar Sep 18 '23 16:09 IamMujuziMoses

@mseaton @dkayiwa please review

IamMujuziMoses avatar Sep 18 '23 16:09 IamMujuziMoses

@IamMujuziMoses your test is not testing the changes in PasswordResetController2_2 because it passes without those changes.

dkayiwa avatar Sep 23 '23 19:09 dkayiwa