openmrs-module-webservices.rest
openmrs-module-webservices.rest copied to clipboard
openmrs
RESTWS-895: Return 204 response when the patient allergy status is unknown
Description of what I changed
Issue I worked on
see https://issues.openmrs.org/browse/RESTWS-895
Checklist: I completed these to help reviewers :)
-
[x] My pull request only contains ONE single commit (the number above, next to the 'Commits' tab is 1).
No? -> read here on how to squash multiple commits into one
-
[x] My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amend -
[ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amend -
[x] I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.No? -> execute above command
-
[ ] All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
-
[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master
With your changes, what happens when one requests for allergies for a patient whose status is unknown?
Nothing is being return to the client.
Then how are you helping the reporter of the problem on talk?
@dkayiwa based on the responses on talk, this commit is now ok to go into master after testing it out.
@kdaud is there a reason why you make a million commits on pull requests like this? Am not against the concept of commit early and often. But your rate of committing on such pull requests looks like you do not first test locally before committing (Are you coding from your phone?). As a result, since am notified for each commit (and i do not want to turn this off), the noise becomes too much. 😊
@dkayiwa have added the test however, its failing as a result of failing to locate the resource. Am using allergy as a resource path though this is failing, what could be the right resource path to be passed in the get() method?
@kdaud your test should not be in that class. It should instead be in the PatientAllergyController2_0Test class.