openmrs-module-webservices.rest icon indicating copy to clipboard operation
openmrs-module-webservices.rest copied to clipboard

RESTWS-813:Strings should not be compared by using == or !=

Open hillarykimo opened this issue 3 years ago • 3 comments

Description of what I changed

I changed the operators from == or != to equals(Object) method on this files https://github.com/openmrs/openmrs-module-webservices.rest/blob/2.28.0/omod-1.8/src/main/java/org/openmrs/module/webservices/rest/web/v1_0/resource/openmrs1_8/ModuleResource1_8.java#L210 https://github.com/openmrs/openmrs-module-webservices.rest/blob/2.28.0/omod-1.8/src/main/java/org/openmrs/module/webservices/rest/web/v1_0/resource/openmrs1_8/TaskDefinitionResource1_8.java#L157 https://github.com/openmrs/openmrs-module-webservices.rest/blob/2.28.0/omod-common/src/main/java/org/openmrs/module/webservices/docs/swagger/SwaggerSpecificationCreator.java#L1041

Issue I worked on

https://issues.openmrs.org/browse/RESTWS-813

  • [ ] My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • [ ] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

    No? -> execute above command

  • [ ] All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • [ ] My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

hillarykimo avatar Jun 06 '21 11:06 hillarykimo

https://github.com/openmrs/openmrs-module-webservices.rest/blob/2.28.0/omod-1.8/src/main/java/org/openmrs/module/webservices/rest/web/v1_0/resource/openmrs1_8/ModuleResource1_8.java#L210 https://github.com/openmrs/openmrs-module-webservices.rest/blob/2.28.0/omod-1.8/src/main/java/org/openmrs/module/webservices/rest/web/v1_0/resource/openmrs1_8/TaskDefinitionResource1_8.java#L157 https://github.com/openmrs/openmrs-module-webservices.rest/blob/2.28.0/omod-common/src/main/java/org/openmrs/module/webservices/docs/swagger/SwaggerSpecificationCreator.java#L1041

Thanks @hillarykimo no need of adding this

HerbertYiga avatar Jun 06 '21 13:06 HerbertYiga

@hillarykimo did you successfully compile these changes with mvn clean install?

dkayiwa avatar Feb 13 '22 20:02 dkayiwa

@dkayiwa his laptop broke down and he is trying to fix it.

jwnasambu avatar Apr 04 '22 22:04 jwnasambu