openmrs-module-webservices.rest icon indicating copy to clipboard operation
openmrs-module-webservices.rest copied to clipboard

Expose LocationService.getAllChildLocations() via REST

Open reagan-meant opened this issue 6 years ago • 2 comments

RESTWS-315:Expose LocationService.getAllChildLocations() via REST Added a new method to expose the getDescendants method of Location class via RESTservices https://issues.openmrs.org/browse/RESTWS-315

Description of what I changed

Issue I worked on

see https://issues.openmrs.org/browse/RESTWS-

Checklist: I completed these to help reviewers :)

  • [ ] My pull request only contains ONE single commit (the number above, next to the 'Commits' tab is 1).

    No? -> read here on how to squash multiple commits into one

  • [ ] My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • [ ] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

    No? -> execute above command

  • [ ] All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • [ ] My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

reagan-meant avatar Sep 05 '19 16:09 reagan-meant

@reagan-meant You should add the ticket id in your commit message https://wiki.openmrs.org/display/docs/Pull+Request+Tips

ODORA0 avatar Sep 08 '19 07:09 ODORA0

@ibacher could you review this?

gracepotma avatar Apr 05 '21 20:04 gracepotma