modified: api/src/main/resources/moduleApplicationContext.xml

[DukeLishebo]

modified:   omod/gulpfile.js
modified:   pom.xml

Description

Related Issue

see https://issues.openmrs.org/browse/RAD-

Checklist:

• [ ] My pull request only contains one single commit.
• [ ] My pull request is based on the latest master branch git pull --rebase upstream master.
• [ ] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.
• [ ] My code follows the code style of this project.
• [ ] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests passed.

[DukeLishebo]

Some of the errors that appear when the module is run on a new core model have been resolved, but still a long way to go.

[DukeLishebo]

Each time I could try to add the module, it kept giving me Spring errors because of version incompatibility. So I started changing the invalid syntax in the moduleContex file and in the pom.xml and then changed the outdated dependencies in the gulf file since an old version of Node was used.

On Thu, Mar 7, 2024 at 1:26 PM dkayiwa @.***> wrote:

@.**** commented on this pull request.

In omod/gulpfile.js https://github.com/openmrs/openmrs-module-radiology/pull/522#discussion_r1516000278 :

@@ -1,83 +1,212 @@ -var gulp = require('gulp'); -var mainBowerFiles = require('main-bower-files'); -var uglify = require('gulp-uglify'); -var cleanCSS = require('gulp-clean-css')

How are the changes in this file related to making the module run on the latest core platform?

— Reply to this email directly, view it on GitHub https://github.com/openmrs/openmrs-module-radiology/pull/522#pullrequestreview-1922187079, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYTE3CO3SEL37BI34N7ZBJLYXBFGZAVCNFSM6AAAAABEJ7UT6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRSGE4DOMBXHE . You are receiving this because you authored the thread.Message ID: @.***>

[DukeLishebo]

To be honest, I am not really sure about where I am supposed to start the updating from.

On Thu, Mar 7, 2024 at 2:04 PM Lishebo Lishebo @.***> wrote:

Each time I could try to add the module, it kept giving me Spring errors because of version incompatibility. So I started changing the invalid syntax in the moduleContex file and in the pom.xml and then changed the outdated dependencies in the gulf file since an old version of Node was used.

On Thu, Mar 7, 2024 at 1:26 PM dkayiwa @.***> wrote:

@.**** commented on this pull request.

In omod/gulpfile.js https://github.com/openmrs/openmrs-module-radiology/pull/522#discussion_r1516000278 :

@@ -1,83 +1,212 @@ -var gulp = require('gulp'); -var mainBowerFiles = require('main-bower-files'); -var uglify = require('gulp-uglify'); -var cleanCSS = require('gulp-clean-css')

How are the changes in this file related to making the module run on the latest core platform?

— Reply to this email directly, view it on GitHub https://github.com/openmrs/openmrs-module-radiology/pull/522#pullrequestreview-1922187079, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYTE3CO3SEL37BI34N7ZBJLYXBFGZAVCNFSM6AAAAABEJ7UT6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRSGE4DOMBXHE . You are receiving this because you authored the thread.Message ID: @.***>

[dkayiwa]

Spring and Node do not look related. I would separate the two.

[dkayiwa]

To be honest, I am not really sure about where I am supposed to start the updating from.

It would be easier for you to do a separate pull request for each category of errors. For instance the changes you made in moduleApplicationContext.xml are correct and deal with a certain category of errors, hence a good candidate for their own pull request.

[DukeLishebo]

Thanks, I was getting the node errors on compilation. Do you think resolving errors one by one will yield something or am I on a wild goose chase here?

On Thu, Mar 7, 2024 at 2:10 PM dkayiwa @.***> wrote:

To be honest, I am not really sure about where I am supposed to start the updating from.

It would be easier for you to do a separate pull request for each category of errors. For instance the changes you made in moduleApplicationContext.xml are correct and deal with a certain category of errors, hence a good candidate for their own pull request.

— Reply to this email directly, view it on GitHub https://github.com/openmrs/openmrs-module-radiology/pull/522#issuecomment-1983378058, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYTE3CMNLIGWQZXCRT36NIDYXBKJ5AVCNFSM6AAAAABEJ7UT6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBTGM3TQMBVHA . You are receiving this because you authored the thread.Message ID: @.***>

[dkayiwa]

Addressing those errors one by one will be the easiest way for you to make progress.

[DukeLishebo]

Alright, Thanks

On Thu, Mar 7, 2024 at 2:35 PM dkayiwa @.***> wrote:

Addressing those errors one by one will be the easiest way for you to make progress.

— Reply to this email directly, view it on GitHub https://github.com/openmrs/openmrs-module-radiology/pull/522#issuecomment-1983418057, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYTE3CKPD6WWZSVAXVHSDODYXBNIBAVCNFSM6AAAAABEJ7UT6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBTGQYTQMBVG4 . You are receiving this because you authored the thread.Message ID: @.***>