openmrs-module-fhir2 icon indicating copy to clipboard operation
openmrs-module-fhir2 copied to clipboard

FM2-636: Enhancements in Existing FHIR Task Resource

Open kalai-tw opened this issue 10 months ago • 4 comments

Description of what I changed

Made below Changes to FHIR Task Entity Model:

  • Added new columns to fhir_task:

    • task_code: to determine task type
    • execution_start_time: start time of execution
    • execution_end_time: end time of execution
    • comment: comment to task
  • Added a new table fhir_part_of_reference to support subtasks to a parent task.

Issue I worked on

see https://issues.openmrs.org/browse/FM2-636 talk thread ref https://talk.openmrs.org/t/contribution-to-fhir-task/42015

Checklist: I completed these to help reviewers :)

  • [x] My IDE is configured to follow the code style of this project.

  • [x] I have added tests to cover my changes.

  • [x] I ran mvn clean package right before creating this pull request

  • [x] All new and existing tests passed.

  • [x] My pull request is based on the latest changes of the master branch.

kalai-tw avatar Apr 10 '24 04:04 kalai-tw

Hello @ibacher ! Thanksa for the feedbacks !

Yeap ! We would need Search By Code & Search By For Reference . Have added them in this new commit !

Also, Have Added the Integrations Tests now :)

kalai-tw avatar Apr 17 '24 19:04 kalai-tw

@kalai-tw do you mind looking into the above failing build?

dkayiwa avatar Apr 23 '24 22:04 dkayiwa

@kalai-tw Could you rebase this branch on master, since we've committed the fix for the test?

ibacher avatar May 16 '24 19:05 ibacher

thanq @ibacher rebased & now the PR pipeline looks green ! can u help on squash & merging the same ?

kalai-tw avatar May 17 '24 05:05 kalai-tw