openmrs-esm-patient-chart icon indicating copy to clipboard operation
openmrs-esm-patient-chart copied to clipboard

(feat) O3-2626: Visit note attach image should be able to attach multiple images

Open jwnasambu opened this issue 10 months ago • 5 comments

Requirements

  • [x] This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • [ ] My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • [ ] My work includes tests or is validated by existing tests.

Summary

I fixed the VisitNotesForm component to allow attaching multiple images without necessarily being an array by adjusting the UploadedFile type to accommodate multiple files and update the related logic.

Screenshots

Uploading screencast 2024-05-01 5 PM-36-32.mp4…

Related Issue

https://openmrs.atlassian.net/browse/O3-2626

Other

jwnasambu avatar Apr 19 '24 08:04 jwnasambu

@ibacher Thanks for the review ref .

jwnasambu avatar Apr 19 '24 09:04 jwnasambu

@ibacher, @denniskigen and @brandones kindly help me review my PR at your convinient time please!

jwnasambu avatar May 01 '24 14:05 jwnasambu

@jwnasambu Are you stuck on any particular point or is this ready for a full review?

ibacher avatar May 03 '24 16:05 ibacher

@ibacher Its ready for review. Thanks for asking.

jwnasambu avatar May 05 '24 13:05 jwnasambu

@ibacher and @denniskigen Kindly am so sorry I have tried to push the changes and even update this PR but all in vain since yesterday and no error thrown to guide me. Kindly I have created this link https://github.com/openmrs/openmrs-esm-patient-chart/pull/1826 with the proposed changes.

jwnasambu avatar May 08 '24 21:05 jwnasambu