openmrs-core icon indicating copy to clipboard operation
openmrs-core copied to clipboard

TRUNK-6296: Replace PowerMock Usage Due to Limited Support in Modern Java Versions

Open wikumChamith opened this issue 11 months ago • 4 comments

Description of what I changed

Issue I worked on

see https://openmrs.atlassian.net/browse/TRUNK-6296

Checklist: I completed these to help reviewers :)

  • [x] My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • [x] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

    No? -> execute above command

  • [x] All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • [x] My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

wikumChamith avatar Jan 31 '25 17:01 wikumChamith

Do we have modules that are still using PowerMock? If yes, what plans do we have for their migration?

dkayiwa avatar Feb 01 '25 22:02 dkayiwa

Do we have modules that are still using PowerMock? If yes, what plans do we have for their migration?

Since PowerMock is only used for testing, this won't impact any modules at runtime. However, moving forward, any module that plans to use the latest version of openmrs-core as a dependency should avoid using PowerMock

wikumChamith avatar Feb 02 '25 04:02 wikumChamith

Do we have modules that are still using PowerMock? If yes, what plans do we have for their migration?

Perhaps this is a plausible temporary solution: https://stackoverflow.com/a/71203428

samuelmale avatar Feb 03 '25 15:02 samuelmale

Do we have modules that are still using PowerMock? If yes, what plans do we have for their migration?

Perhaps this is a plausible temporary solution: https://stackoverflow.com/a/71203428

We used that here: https://github.com/openmrs/openmrs-module-uiframework/commit/ff12904b14ebb3eea181888887c4075677f5362c

However, it would be better to try to avoid it.

wikumChamith avatar Feb 03 '25 15:02 wikumChamith