openmrs-core icon indicating copy to clipboard operation
openmrs-core copied to clipboard

TRUNK-5964: Hard-coded uuids for drug order type and test order type.

Open IamMujuziMoses opened this issue 11 months ago • 4 comments

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-5964

Checklist: I completed these to help reviewers :)

  • [ ] My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • [ ] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

    No? -> execute above command

  • [ ] All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • [ ] My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

IamMujuziMoses avatar Mar 13 '24 08:03 IamMujuziMoses

@IamMujuziMoses - thanks for this work. How different is this approach from the current/existing implementation? What gaps are we addressing?

ojwanganto avatar Mar 13 '24 08:03 ojwanganto

@ojwanganto thanks for the feedback, this PR is intended to implement a better and more correct approach to remove any dependency on the specific hard-coded uuids for drug order type and test order type as stated in this ticket

IamMujuziMoses avatar Mar 13 '24 09:03 IamMujuziMoses

@mseaton @dkayiwa @ibacher could you please review this PR, your feedback will be appreciated

IamMujuziMoses avatar Mar 13 '24 09:03 IamMujuziMoses

@IamMujuziMoses got it. I have also checked the linked ticket. Thanks

ojwanganto avatar Mar 13 '24 11:03 ojwanganto