openmrs-core icon indicating copy to clipboard operation
openmrs-core copied to clipboard

Published 20 hours ago • verified publisher icon openmrs

TRUNK-5767: Switch core from mxj to mariaDB4j

Open kdaud opened this issue 2 years ago • 7 comments

Description of what I changed

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-5767

Checklist: I completed these to help reviewers :)

  • [x ] My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • [x ] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

    No? -> execute above command

  • [ ] All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • [x ] My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

kdaud avatar Apr 21 '22 08:04 kdaud

@kdaud did you test this?

dkayiwa avatar Apr 21 '22 09:04 dkayiwa

Yes!

What have done is to build the core with the changes, after a successful build plan have got the openmrs.war file and tested it with my local server and the refapp is running well without any issue.

kdaud avatar Apr 21 '22 09:04 kdaud

Take a look at this: https://wiki.openmrs.org/display/docs/OpenMRS+Standalone

Sorry for the ticket not being properly written. But our goal is for this to replace the OpenMRS Standalone in-memory mysql with mariadb. So for this to be fully done, one should be able to run the standalone with an embedded mariadb.

dkayiwa avatar Apr 21 '22 09:04 dkayiwa

Hope am getting it right based on the comment above, work is supposed to be done on openmrs-standandalone module!

kdaud avatar Apr 21 '22 10:04 kdaud

@kdaud how did you run the OpenMRS Standalone? Did you make changes to the openmrs standalone, build it and run to confirm that it is now running on Mariadb?

dkayiwa avatar Apr 21 '22 10:04 dkayiwa

@kdaud how did you run the OpenMRS Standalone?

Haven't done this at the moment.

What I did was to test the openmrs.war file with the changes on a local server generated by sdk .

kdaud avatar Apr 21 '22 10:04 kdaud

tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare!

This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. Please note that this is an automated message and we might very well be the reason why there has not been any activity lately. We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs.

If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) If you would like to continue working on it or require help from us please remove the stale label and respond by commenting on the issue.

github-actions[bot] avatar Sep 19 '22 00:09 github-actions[bot]