openmrs-core icon indicating copy to clipboard operation
openmrs-core copied to clipboard

TRUNK-5087 : Added unit tests for OpenmrsUtils

Open LuGO0 opened this issue 3 years ago • 5 comments

Description of what I changed

  1. Added tests for methods which did not require context.
  2. Modified documentation for an exisiting util method.

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-5087

Checklist: I completed these to help reviewers :)

  • [ ] My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • [ ] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

    No? -> execute above command

  • [ ] All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • [ ] My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

LuGO0 avatar Dec 12 '21 10:12 LuGO0

@sherrif10 @HerbertYiga please review.

LuGO0 avatar Dec 12 '21 10:12 LuGO0

inviting @dkayiwa to have a second look onto this too

HerbertYiga avatar Dec 23 '21 22:12 HerbertYiga

@HerbertYiga can we close the Issue by merging this pending PR?

LuGO0 avatar Jan 29 '22 17:01 LuGO0

can we close the Issue by merging this pending PR?

cc @dkayiwa

HerbertYiga avatar Jan 30 '22 13:01 HerbertYiga

tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare!

This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. Please note that this is an automated message and we might very well be the reason why there has not been any activity lately. We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs.

If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) If you would like to continue working on it or require help from us please remove the stale label and respond by commenting on the issue.

github-actions[bot] avatar Jul 18 '22 00:07 github-actions[bot]

tl;dr closing this PR since it has not seen any activity in the last 6 months.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare! We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs. Your PR has not seen any activity in the last 6 months. This is why we have decided to close this PR for now. This allows us OpenMRS reviewers to focus our limited time to review all other PRs in a timely and professional manner.

Please feel free to reassign yourself to the issue you worked on in our JIRA when you have time to focus on it. After that reopen a new PR and we will be glad to work with you to get your contribution merged. Thank you very much for your help and understanding :)

github-actions[bot] avatar Aug 17 '22 00:08 github-actions[bot]