openmrs-core icon indicating copy to clipboard operation
openmrs-core copied to clipboard

TRUNK-5535:Upgrade org.codehaus Libraries

Open hillarykimo opened this issue 3 years ago • 10 comments

Description of what I changed

I changed from <jacksonVersion>2.12.5</jacksonVersion> to <jacksonVersion>2.13.0</jacksonVersion> based on this https://mvnrepository.com/artifact/org.codehaus.jackson/jackson-mapper-asl

Issue I worked on

https://issues.openmrs.org/browse/TRUNK-5535

hillarykimo avatar Sep 12 '21 12:09 hillarykimo

@dkayiwa kindly review my PR at your convenient time.

hillarykimo avatar Sep 12 '21 12:09 hillarykimo

Isn't rc a release candidate. If so, i would wait for the final release.

dkayiwa avatar Sep 13 '21 08:09 dkayiwa

@dkayiwa thank you. let me wait for the release

hillarykimo avatar Sep 13 '21 09:09 hillarykimo

thank you. let me wait for the release

@hillarykimo though it looks like its arleady out https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-core

HerbertYiga avatar Sep 13 '21 12:09 HerbertYiga

@HerbertYiga I had followed the same link but it seems there is a final release after 2.13.0-rc2 which is a candidate release

hillarykimo avatar Sep 13 '21 12:09 hillarykimo

@dkayiwa The library updated itself automatically to the current full release and I have just fixed the merge conflict. kindly confirm if its the right version. thank

hillarykimo avatar Oct 19 '21 14:10 hillarykimo

This pull request simply has a formatting change. No version change.

dkayiwa avatar Oct 19 '21 14:10 dkayiwa

@dkayiwa I need you help please ! I have tried to change the library version from my IDE but its already update to the current release. How can I go about it to insure it reflects the version change and not formatted version. thank you

hillarykimo avatar Oct 19 '21 15:10 hillarykimo

Do you mind asking this from Talk?

dkayiwa avatar Oct 19 '21 22:10 dkayiwa

tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare!

This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. Please note that this is an automated message and we might very well be the reason why there has not been any activity lately. We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs.

If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) If you would like to continue working on it or require help from us please remove the stale label and respond by commenting on the issue.

github-actions[bot] avatar Jul 19 '22 00:07 github-actions[bot]

tl;dr closing this PR since it has not seen any activity in the last 6 months.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare! We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs. Your PR has not seen any activity in the last 6 months. This is why we have decided to close this PR for now. This allows us OpenMRS reviewers to focus our limited time to review all other PRs in a timely and professional manner.

Please feel free to reassign yourself to the issue you worked on in our JIRA when you have time to focus on it. After that reopen a new PR and we will be glad to work with you to get your contribution merged. Thank you very much for your help and understanding :)

github-actions[bot] avatar Aug 19 '22 00:08 github-actions[bot]