openmrs-core icon indicating copy to clipboard operation
openmrs-core copied to clipboard

Improve MAVEN build Performance

Open ChenZhangg opened this issue 2 years ago • 7 comments

Parallel builds in Maven 3 Maven 3.x has the capability to perform parallel builds.

Apache Maven Dependency Plugin can be used to find unused dependencies. And I found following list. Maybe we can remove them. openmrs openmrs-tools openmrs-test openmrs-api {groupId='org.openmrs.test', artifactId='openmrs-test'} {groupId='org.powermock', artifactId='powermock-reflect'} {groupId='org.azeckoski', artifactId='reflectutils'} {groupId='org.springframework', artifactId='spring-jdbc'} {groupId='ca.uhn.hapi', artifactId='hapi-structures-v23'} {groupId='ca.uhn.hapi', artifactId='hapi-structures-v24'} {groupId='ca.uhn.hapi', artifactId='hapi-structures-v26'} {groupId='org.javassist', artifactId='javassist'} {groupId='org.hibernate', artifactId='hibernate-c3p0'} {groupId='org.hibernate', artifactId='hibernate-ehcache'} {groupId='org.apache.lucene', artifactId='lucene-backward-codecs'} {groupId='org.apache.logging.log4j', artifactId='log4j-slf4j-impl'} {groupId='org.jboss.logging', artifactId='jboss-logging'} {groupId='org.slf4j', artifactId='log4j-over-slf4j'} {groupId='xerces', artifactId='xercesImpl'} {groupId='javax.validation', artifactId='validation-api'} {groupId='org.hibernate', artifactId='hibernate-validator'} {groupId='mysql', artifactId='mysql-connector-java'} {groupId='org.codehaus.jackson', artifactId='jackson-mapper-asl'} {groupId='com.fasterxml.jackson.core', artifactId='jackson-core'} {groupId='com.fasterxml.jackson.core', artifactId='jackson-annotations'} {groupId='com.fasterxml.jackson.core', artifactId='jackson-databind'} {groupId='org.codehaus.groovy', artifactId='groovy-all'} {groupId='org.aspectj', artifactId='aspectjrt'} {groupId='org.aspectj', artifactId='aspectjweaver'} {groupId='joda-time', artifactId='joda-time'} {groupId='com.sun.activation', artifactId='javax.activation'} {groupId='jakarta.xml.bind', artifactId='jakarta.xml.bind-api'} {groupId='com.sun.xml.bind', artifactId='jaxb-impl'} openmrs-web {groupId='org.openmrs.test', artifactId='openmrs-test'} {groupId='javax.servlet', artifactId='jsp-api'} {groupId='javax.servlet.jsp.jstl', artifactId='javax.servlet.jsp.jstl-api'} {groupId='org.springframework', artifactId='spring-oxm'} {groupId='mysql', artifactId='mysql-connector-java'} {groupId='org.postgresql', artifactId='postgresql'} {groupId='taglibs', artifactId='request'} {groupId='taglibs', artifactId='response'} {groupId='taglibs', artifactId='standard'} {groupId='taglibs', artifactId='page'} {groupId='org.slf4j', artifactId='jcl-over-slf4j'} openmrs-webapp {groupId='org.openmrs.api', artifactId='openmrs-api'} {groupId='org.openmrs.web', artifactId='openmrs-web'} openmrs-liquibase {groupId='jaxen', artifactId='jaxen'} {groupId='mysql', artifactId='mysql-connector-java'} {groupId='org.apache.logging.log4j', artifactId='log4j-slf4j-impl'}

According to Maven parallel test, we can run tests in parallel.

===================== If there are any inappropriate modifications in this PR, please give me a reply and I will change them.

ChenZhangg avatar Aug 26 '21 01:08 ChenZhangg

Thanks @ChenZhangg for this contribution! Do you mind taking a look at the above build failures?

dkayiwa avatar Aug 26 '21 08:08 dkayiwa

ok I will check the build log

ChenZhangg avatar Aug 26 '21 08:08 ChenZhangg

Apache Maven Dependency Plugin may not be accurate........

ChenZhangg avatar Aug 26 '21 09:08 ChenZhangg

@ChenZhangg do you have any update on this?

dkayiwa avatar Nov 12 '21 11:11 dkayiwa

no, can u merge this pr?

chenzhang22 avatar Nov 15 '21 01:11 chenzhang22

@YunLemon i have run these changes several times without noticing any improvement in the build performance. Is it the same experience on your side?

dkayiwa avatar Nov 15 '21 11:11 dkayiwa

tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare!

This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. Please note that this is an automated message and we might very well be the reason why there has not been any activity lately. We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs.

If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) If you would like to continue working on it or require help from us please remove the stale label and respond by commenting on the issue.

github-actions[bot] avatar Jul 20 '22 00:07 github-actions[bot]

tl;dr closing this PR since it has not seen any activity in the last 6 months.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare! We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs. Your PR has not seen any activity in the last 6 months. This is why we have decided to close this PR for now. This allows us OpenMRS reviewers to focus our limited time to review all other PRs in a timely and professional manner.

Please feel free to reassign yourself to the issue you worked on in our JIRA when you have time to focus on it. After that reopen a new PR and we will be glad to work with you to get your contribution merged. Thank you very much for your help and understanding :)

github-actions[bot] avatar Aug 19 '22 00:08 github-actions[bot]