TRUNK-5954 Exception classes should be immutable

[bejanut]

Description of what I changed

Made fields in exception classes immutable and modified constructors in order to incorporate the new changes.

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-5954

Checklist: I completed these to help reviewers :)

• [x] My IDE is configured to follow the code style of this project.

  No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

• [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

  No? -> write tests and add them to this commit git add . && git commit --amend

• [x] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

  No? -> execute above command

• [x] All new and existing tests passed.

  No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

• [x] My pull request is based on the latest changes of the master branch.

  No? Unsure? -> execute command git pull --rebase upstream master

[coveralls]

Coverage increased (+53.3%) to 63.607% when pulling a77e639160410a7fbfbbc559b5a3341661a80ee0 on bejanut:TRUNK-5954 into 52481fcfe79ab63e3a62ca7901a45364f1579531 on openmrs:master.

[Wandji69]

@bejanut can you squash your commits into one single commit.

[Wandji69]

@bejanut can you check the travis logs to see which test is failing.

[Wandji69]

@bejanut can you squash your commits into one single commit

[bejanut]

@Wandji69 I think I managed to squash them.

[bejanut]

@Wandji69 Apparently after squashing the commits into a single one, Travis CI threw an error, but I can seems to make out what it is. It is confusing because is the same code that previously passed the tests.

[bejanut]

@sacull @Wandji69 Anything left that I could do?

[dkayiwa]

@bejanut i have just rerun travis and it is now good. There is a randomly failing test which we need to fix. Not your problem though.

[bejanut]

@dkayiwa Thank you for the information! Any advice on this PR?

Also do you believe here is the same problem with the Travis? https://github.com/openmrs/openmrs-core/pull/3729

[dkayiwa]

Yes it is exactly the same problem.

[bejanut]

Yes it is exactly the same problem.

Thank you! It was confusing.

[bejanut]

Any updates? Suggestions?

[dkayiwa]

@sacull what do you think of this?

[dkayiwa]

@bejanut can you look into these merge conflicts?

[bejanut]

@bejanut can you look into these merge conflicts?

Yes I'll look into it and fix them as quick as possible

[bejanut]

@dkayiwa is the Travis CI problem still persisting or is it a privoem in my code?

[dkayiwa]

@bejanut it was a randomly failing test. I have just rerun the build.

[bejanut]

@bejanut it was a randomly failing test. I have just rerun the build.

Thank you! Is there anything else I should do?

[bejanut]

@dkayiwa I have updated my code following your advice? Anything more that I could do?

[sherrif10]

Hello @HerbertYiga could you followup on this thanks.

[sherrif10]

Hello @dkayiwa Requesting for reviews.

[HerbertYiga]

hi @dkayiwa @ibacher does this look good to be merged?

[github-actions[bot]]

tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare!

This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. Please note that this is an automated message and we might very well be the reason why there has not been any activity lately. We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs.

If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) If you would like to continue working on it or require help from us please remove the stale label and respond by commenting on the issue.

[github-actions[bot]]

tl;dr closing this PR since it has not seen any activity in the last 6 months.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare! We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs. Your PR has not seen any activity in the last 6 months. This is why we have decided to close this PR for now. This allows us OpenMRS reviewers to focus our limited time to review all other PRs in a timely and professional manner.

Please feel free to reassign yourself to the issue you worked on in our JIRA when you have time to focus on it. After that reopen a new PR and we will be glad to work with you to get your contribution merged. Thank you very much for your help and understanding :)