TRUNK-247 - Added required values constructors to java objects

[xurror]

Description of what I changed

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-247

Checklist: I completed these to help reviewers :)

• [ ] My IDE is configured to follow the code style of this project.

  No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

• [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

  No? -> write tests and add them to this commit git add . && git commit --amend

• [ ] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

  No? -> execute above command

• [x] All new and existing tests passed.

  No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

• [x] My pull request is based on the latest changes of the master branch.

  No? Unsure? -> execute command git pull --rebase upstream master

[coveralls]

Coverage decreased (-0.7%) to 62.973% when pulling c955a490c706a7cc0de84bb725378e328eb1bd83 on xurror:TRUNK-247 into b1a7981003ccea0e352c1f526d27acc495a37053 on openmrs:master.

[HerbertYiga]

@xurror thanks for working on this,have you seen the breaking Travis, checkout the travis ci to see what is breaking for this!

[xurror]

Yes. I'm getting to it in a minute. I'll ping a maintainer once it's good for review.

On Tue, 16 Mar 2021 at 21:22, HerbertYiga @.***> wrote:

@xurror https://github.com/xurror thanks for working on this,have you seen the breaking Travis, checkout the travis ci to see what is breaking for this!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openmrs/openmrs-core/pull/3726#issuecomment-800576548, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK5B5DC54UN6ESPPY6OW6U3TD64W7ANCNFSM4ZH6JZVQ .

[Wandji69]

@xurror some test are still failing do check the travis logs

[xurror]

@Wandji69, @HerbertYiga I still have some issues with improving coveralls coverage. Some of the classes could not be tested on their own as they serve mostly a supper classes for other classes and thus could not be tested individually. I have incorporated the feedback I read in a previous PR https://github.com/openmrs/openmrs-core/pull/3139 about this issue to the best I could but the testing side is still lagging. If you have some suggestions on how to improve them, I'll gladly incorporate them.

[xurror]

Also, @ibacher please can you review?

[Wandji69]

@xurror I will run this on my end and see if I get any error, BTW, your issue link is not correct.

[xurror]

@xurror I will run this on my end and see if I get any error, BTW, your issue link is not correct.

Thanks for the update.

[sherrif10]

cc @dkayiwa @ibacher , Kindly review. thanks

[github-actions[bot]]

tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare!

This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. Please note that this is an automated message and we might very well be the reason why there has not been any activity lately. We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs.

If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) If you would like to continue working on it or require help from us please remove the stale label and respond by commenting on the issue.

[github-actions[bot]]

tl;dr closing this PR since it has not seen any activity in the last 6 months.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare! We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs. Your PR has not seen any activity in the last 6 months. This is why we have decided to close this PR for now. This allows us OpenMRS reviewers to focus our limited time to review all other PRs in a timely and professional manner.

Please feel free to reassign yourself to the issue you worked on in our JIRA when you have time to focus on it. After that reopen a new PR and we will be glad to work with you to get your contribution merged. Thank you very much for your help and understanding :)