Fix breaking date for TRUNK-5101

[HerbertYiga]

Ticket Id:https://issues.openmrs.org/browse/TRUNK-5101

Description

changes here https://github.com/openmrs/openmrs-core/pull/3195 were breaking due to an early expiry date, introduced a more later expiry date cc @dkayiwa @ibacher

[coveralls]

Coverage decreased (-0.03%) to 63.67% when pulling 2afe9a9e49b84413ff1dfaec91b471c5a2e7c5a8 on HerbertYiga:FOLLOW_UP_COMMIT_ON_TRUNK_5101; into c43410914899cbca90fd1487d7a3cd0fa7695a51 on openmrs:master.

[HerbertYiga]

@dkayiwa hi Dan, any comments on this?

[dkayiwa]

@HerbertYiga i prefer commit messages which deal with what the actual change is about. Instead of generic ones like follow up commit ...

[HerbertYiga]

@HerbertYiga i prefer commit messages which deal with what the actual change is about. Instead of generic ones like follow up commit ...

@dkayiwa i have included a better commit message

[dkayiwa]

Can you use a proper ticket number? Any reason for the capitalization in your message?

[HerbertYiga]

Can you use a proper ticket number? Any reason for the capitalization in your message?

@dkayiwa Fixed this,thanks

[dkayiwa]

@HerbertYiga is this what was agreed upon via the JIRA ticket comments?

[HerbertYiga]

is this what was agreed upon via the JIRA ticket comments?

well i could

is this what was agreed upon via the JIRA ticket comments? @dkayiwa it suggests to have the expiry date at a later date by having the current date and adding a future date, done this in my changes

[dkayiwa]

please check if you can dynamically create this data that you need in the setup of the test. Otherwise we will have the same scenario on the day of the expiry date in the near future.

[HerbertYiga]

Hi @dkayiwa does this look fine to you now?

[HerbertYiga]

hi @dkayiwa does this look good for merging?

[Wandji69]

@HerbertYiga please also check why the test still fails even with these changes.

[HerbertYiga]

please also check why the test still fails even with these changes.

i get this test passing well at my side @Wandji69 how are you testing this?

[HerbertYiga]

@HerbertYiga please also check why the test still fails even with these changes.

hi @Wandji69 are you available so that we pass through this because nothing breaks at my side so as we can get it merged cc @dkayiwa

[Wandji69]

Hi @HerbertYiga I have tested this and it's successful at my end. I thing the Coverall failure is not due to the changes you have made. @dkayiwa please can you check this too.

B.R Collins C. Wandji No: +237672965154 https://Wandji69.me

[gracepotma]

@HerbertYiga can you respond to @Wandji69 above? Once that's done you can tag @dkayiwa for review.

[HerbertYiga]

@HerbertYiga can you respond to @Wandji69 above? Once that's done you can tag @dkayiwa for review.

@gracepotma According to @Wandji69 's comments this is good to be merged cc @dkayiwa

[HerbertYiga]

since GitHub actions bot now closes pull requests that have not been active after some time, trying to re-ping @dkayiwa @gracepotma to see whether this is now good for merging!

[dkayiwa]

@HerbertYiga if you are still working on this, it has some merge conflicts.

[sherrif10]

Hello @HerbertYiga can you please resolve merge conflicts.

[HerbertYiga]

on trying to resolve merge conflicts for this,not sure why i cannot squash my commits any more,could i be messing up some thing cc @dkayiwa @ibacher

[HerbertYiga]

hi @dkayiwa does this look good to be merged in now basing on all the previous comments?

[HerbertYiga]

hi @dkayiwa am happy to have this merged if there no objections

[HerbertYiga]

@ibacher hi ian i did fix this basing on the above comments

[HerbertYiga]

hi @ibacher,just re -pinging you about this,thanks

[github-actions[bot]]

tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare!

This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. Please note that this is an automated message and we might very well be the reason why there has not been any activity lately. We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs.

If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) If you would like to continue working on it or require help from us please remove the stale label and respond by commenting on the issue.