RA-552:Adding the View Logged in Users functionality to core

[HerbertYiga]

ticket Id:https://issues.openmrs.org/browse/RA-552

Adding the View Logged in Users functionality to core

[sherrif10]

Thanks @HerbertYiga feel free to check out my comment on the ticket, however i would also think this should be fixed in legacyui

[HerbertYiga]

thanks @sharif this exists in ui and a suggestion came in to have it under core

[sherrif10]

Do you mind pointing me to that thread talking about core please thanks

[HerbertYiga]

its this @sherrif10 https://talk.openmrs.org/t/view-logged-in-users-is-empty/19348/4

[dkayiwa]

@HerbertYiga did you see the travis build failure?

[HerbertYiga]

@dkayiwa yes i saw the Travis build failure, this breaks because i didn't include the HttpSession and ServletContext dependencies at core.Is there any reason why we don't implement HttpSession and ServletContext at core? cc @dkayiwa @ibacher

[coveralls]

Coverage increased (+53.3%) to 63.583% when pulling 0c6e57214cd37877e1bafcc1f80a49b3b1c827c6 on HerbertYiga:RA-552 into bae850075e4436983a3b90e8f99510632001c772 on openmrs:master.

[sherrif10]

its this @sherrif10 https://talk.openmrs.org/t/view-logged-in-users-is-empty/19348/4

Thanks @HerbertYiga for the link sorry for late response

[HerbertYiga]

@dkayiwa how do things look on this pr,the travis breaks only for openjdk 10

[HerbertYiga]

hi @dkayiwa i have included logged in users for the tests

[dkayiwa]

@HerbertYiga did you run the web application and confirm that this is behaving as expected?

[HerbertYiga]

did you run the web application and confirm that this is behaving as expected?

@dkayiwa my plan around this is to access the introduced method from reference application module so that i create a view there, could this be a right direction?

[HerbertYiga]

my plan around this is to access the introduced method from reference application module so that i create a view there, could this be a right direction?

@dkayiwa added some comments here!!

[dkayiwa]

@HerbertYiga i do not dictate the right direction.

[dkayiwa]

@HerbertYiga are you still working on this?

[HerbertYiga]

@HerbertYiga are you still working on this?

Am trying to create a page from which we can view the logged in users from ref app for this

[HerbertYiga]

@HerbertYiga are you still working on this?

Am trying to create a page from which we can view the logged in users from ref app for this

i will be making a pr for the page for this soon

[dkayiwa]

@HerbertYiga you do not need to create a new page for this. All you need is make the existing one use these new changes. Does this make sense?

[HerbertYiga]

you do not need to create a new page for this. All you need is make the existing one use these new changes. Does this make sense?

@dkayiwa the statement got me confused a bit, my approach was to create a list to display users after calling (getCurrentUsers). And this line confused me (All you need is make the existing one use these new changes),does this mean we arleady have a page that shows an existing users under ref app,i am only aware of one under legacy ui?

[dkayiwa]

Did you test with the legacyui?

[HerbertYiga]

@HerbertYiga you do not need to create a new page for this. All you need is make the existing one use these new changes. Does this make sense?

@dkayiwa it got me confused some how,i was

Did you test with the legacyui?

@dkayiwa not really, since the same code exists at the legacy ui

[HerbertYiga]

@dkayiwa let me go on to test with the legacy ui

[HerbertYiga]

Did you test with the legacyui?

hi @dkayiwa , i have tested this on a running instance of openmrs under the legacy ui module,the changes i made under the legacy ui are reflected by this pr https://github.com/openmrs/openmrs-module-legacyui/pull/145 .I have also added the screen shots on the ticked Id.they are named as 1)One and 2)Two , One shows the user name when a single user is logged in while Two shows the list of logged in users whom i have tested using two browsers by logging in each on a different browser.

[dkayiwa]

@HerbertYiga you also need to test with the CurrentUsers class deleted from the legacyui module.

[HerbertYiga]

you also need to test with the CurrentUsers class deleted from the legacyui module.

@dkayiwa ok let me do that

[HerbertYiga]

you also need to test with the CurrentUsers class deleted from the legacyui module.

@dkayiwa dropped current users from legacy as seen here https://github.com/openmrs/openmrs-module-legacyui/pull/145, tested and all was well,i added the screen shots on the ticket ID ie

1)onDeletingCurrentUsersFromLegacy1

2. onDeletingCurrentUsersFromLegacy2

[HerbertYiga]

@dkayiwa the discussion on irc has been really help full, made some changes here thanks

[dkayiwa]

@HerbertYiga have you run the web application again in debug mode and confirmed that CurrentUsers.addUser() is being called?

[HerbertYiga]

have you run the web application again in debug mode and confirmed that CurrentUsers.addUser() is being called?

picked up on this

[HerbertYiga]

hi @dkayiwa tested this with a running instance of openmrs and i see now the CurrentUsers.addUser() from core is used,i have added the current screenshot to the ticket id