openmrs-core icon indicating copy to clipboard operation
openmrs-core copied to clipboard

TRUNK-5963 -Adding Order Context to Order Group

Open tendomart opened this issue 4 years ago • 9 comments

Description of what I changed

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-5963

Checklist: I completed these to help reviewers :)

  • [ ] My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • [ ] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

    No? -> execute above command

  • [ ] All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • [ ] My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@ibacher do you think this is the right path according to description.?

tendomart avatar Nov 27 '20 15:11 tendomart

Hi @tendomart . Please Try to review your checklists. Your code seems okay. Travis build failed. Please try looking again.

joachim-junior avatar Mar 08 '21 10:03 joachim-junior

@tendomart Your code seem to be good, there was a problem with the Travis CI testing, maybe you can add a new commit and see if the problem persists.

bejanut avatar Mar 30 '21 10:03 bejanut

Ooh thanks @joachim-junior and @bejanut for the reviews .Iam gonna look at the Travis logs and rectify the failure .

tendomart avatar Mar 30 '21 10:03 tendomart

Ooh thanks @joachim-junior and @bejanut for the reviews .Iam gonna look at the Travis logs and rectify the failure .

I glad you're back on track and I'll keep looking if the test persists to see if I could help.

bejanut avatar Mar 30 '21 11:03 bejanut

Screenshot from 2021-04-23 18-18-23 A Screenshot of the database for the new columns in order_group table i.e care_setting and order_type_id

tendomart avatar Apr 23 '21 15:04 tendomart

Coverage Status

Coverage increased (+53.3%) to 63.618% when pulling 8a1abbf24b8d2d27d7e22d9a59ccb5255a018f3d on tendomart:TRUNK-5963 into 3d8f176969c84ea0d5b6fa8f8eaccf9685e88a96 on openmrs:master.

coveralls avatar Apr 27 '21 16:04 coveralls

Thanks @tendomart , there are some merge conflicts to resolve.Thanks.

sherrif10 avatar Aug 10 '21 13:08 sherrif10

Everything was cleaned up in the last commit , Iam not really sure why this is still here ..

tendomart avatar Aug 11 '21 14:08 tendomart

tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare!

This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. Please note that this is an automated message and we might very well be the reason why there has not been any activity lately. We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs.

If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) If you would like to continue working on it or require help from us please remove the stale label and respond by commenting on the issue.

github-actions[bot] avatar Feb 13 '22 00:02 github-actions[bot]

tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare!

This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. Please note that this is an automated message and we might very well be the reason why there has not been any activity lately. We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs.

If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) If you would like to continue working on it or require help from us please remove the stale label and respond by commenting on the issue.

github-actions[bot] avatar Aug 18 '22 00:08 github-actions[bot]

tl;dr closing this PR since it has not seen any activity in the last 6 months.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare! We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs. Your PR has not seen any activity in the last 6 months. This is why we have decided to close this PR for now. This allows us OpenMRS reviewers to focus our limited time to review all other PRs in a timely and professional manner.

Please feel free to reassign yourself to the issue you worked on in our JIRA when you have time to focus on it. After that reopen a new PR and we will be glad to work with you to get your contribution merged. Thank you very much for your help and understanding :)

github-actions[bot] avatar Sep 18 '22 00:09 github-actions[bot]