openmrs-core icon indicating copy to clipboard operation
openmrs-core copied to clipboard

TRUNK-5721: Complex obs valueComplex should be more robust to String

Open HerbertYiga opened this issue 4 years ago • 8 comments

https://issues.openmrs.org/browse/TRUNK-5721

What I did: Made sure that a null file is not passed on to cause capturing of a null file name

HerbertYiga avatar Apr 25 '20 19:04 HerbertYiga

Coverage Status

Coverage increased (+0.003%) to 60.46% when pulling 2456b2d3bc536bb6d97604aaecff3c468193d7a7 on HerbertYiga:TRUNK-5721 into d16c00515d31f47bf1b852f763597f0254c7398e on openmrs:master.

coveralls avatar Apr 25 '20 19:04 coveralls

tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare!

This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. Please note that this is an automated message and we might very well be the reason why there has not been any activity lately. We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs.

If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) If you would like to continue working on it or require help from us please remove the stale label and respond by commenting on the issue.

github-actions[bot] avatar Jun 15 '21 00:06 github-actions[bot]

since GitHub actions bot now closes pull requests that have not been active after some time, trying to re-ping @dkayiwa @gracepotma to see whether this is now good for merging!

HerbertYiga avatar Jun 21 '21 18:06 HerbertYiga

Hello cc @dkayiwa @ibacher Kindly review.Thanks.

sherrif10 avatar Sep 28 '21 13:09 sherrif10

cc @HerbertYiga.

sherrif10 avatar Nov 09 '21 13:11 sherrif10

hi @dkayiwa @ibacher is this good enough now?

HerbertYiga avatar Feb 08 '22 13:02 HerbertYiga

Hello @dkayiwa @ibacher How does this look .

sherrif10 avatar Mar 08 '22 13:03 sherrif10

tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare!

This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. Please note that this is an automated message and we might very well be the reason why there has not been any activity lately. We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs.

If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) If you would like to continue working on it or require help from us please remove the stale label and respond by commenting on the issue.

github-actions[bot] avatar Oct 04 '22 00:10 github-actions[bot]