mobility-data-specification icon indicating copy to clipboard operation
mobility-data-specification copied to clipboard

Feature modes delivery

Open tristan-charreton opened this issue 3 years ago • 1 comments

Explain pull request

Work on deliveries to incorporate into Modes

Is this a breaking change

  • Yes, breaking

Impacted Spec

Which spec(s) will this pull request impact?

  • agency
  • policy
  • provider

tristan-charreton avatar Jul 19 '22 16:07 tristan-charreton

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 19 '22 16:07 CLAassistant

@tristan-charreton Can you make sure the 'Allow Edits by Maintainers' checkbox in your pull request? That will allow me to clean up some of your work to align to other parts of the modes work. See if you can edit the PR and check it. If not, you will have to delete this PR then recreate with a new PR.

See bottom of this screenshot:

Screen Shot 2022-09-08 at 3 26 13 PM

schnuerle avatar Sep 08 '22 19:09 schnuerle

Closing this PR before recreating it to allow maintainers to edit.

tristan-charreton avatar Sep 12 '22 08:09 tristan-charreton

Hello @schnuerle I reopen the PR as even when creating a new PR, I do not find the "allow edits by maintainers" checkbox. Checkbox

tristan-charreton avatar Sep 12 '22 08:09 tristan-charreton

@tristan-charreton I'm not sure why this isn't showing up for you, sorry! It has happened before. I think it's due to permissions/settings on the source organization/repo/branch on GitHub, in this case https://github.com/kiwibot-data/mobility-data-specification/tree/feature-modes-delivery

I know it would work if you took that Kiwibot branch and cloned it to your own account, then used that branch to make the pull request.

schnuerle avatar Sep 12 '22 13:09 schnuerle